diff options
author | Linus Torvalds <[email protected]> | 2020-10-11 11:18:04 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2020-10-11 11:18:04 -0700 |
commit | 3dd0130f2430decf0cb001b452824515436986d2 (patch) | |
tree | 3d3bb4ca9c5fe7372eb499bf9983d514ec2f5477 | |
parent | 5b697f86f9f136d200c9827d6eca0437b7eb96cf (diff) | |
parent | 4aab2be0983031a05cb4a19696c9da5749523426 (diff) |
Merge branch 'akpm' (patches from Andrew)
Merge misc fixes from Andrew Morton:
"Five fixes.
Subsystems affected by this patch series: MAINTAINERS, mm/pagemap,
mm/swap, and mm/hugetlb"
* emailed patches from Andrew Morton <[email protected]>:
mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged
mm: validate inode in mapping_set_error()
mm: mmap: Fix general protection fault in unlink_file_vma()
MAINTAINERS: Antoine Tenart's email address
MAINTAINERS: change hardening mailing list
-rw-r--r-- | .mailmap | 4 | ||||
-rw-r--r-- | MAINTAINERS | 8 | ||||
-rw-r--r-- | include/linux/khugepaged.h | 5 | ||||
-rw-r--r-- | include/linux/pagemap.h | 3 | ||||
-rw-r--r-- | mm/khugepaged.c | 13 | ||||
-rw-r--r-- | mm/mmap.c | 6 | ||||
-rw-r--r-- | mm/page_alloc.c | 3 |
7 files changed, 33 insertions, 9 deletions
@@ -41,7 +41,8 @@ Andrew Murray <[email protected]> <[email protected]> Andrew Vasquez <[email protected]> Andrey Ryabinin <[email protected]> <[email protected]> Andy Adamson <[email protected]> -Antoine Tenart <[email protected]> +Antoine Tenart <[email protected]> <[email protected]> +Antoine Tenart <[email protected]> <[email protected]> Antonio Ospite <[email protected]> <[email protected]> Archit Taneja <[email protected]> Ard Biesheuvel <[email protected]> <[email protected]> @@ -188,6 +189,7 @@ Leon Romanovsky <[email protected]> <[email protected]> Linas Vepstas <[email protected]> Linus Lüssing <[email protected]> <[email protected]> Linus Lüssing <[email protected]> <[email protected]> Li Yang <[email protected]> <[email protected]> Li Yang <[email protected]> <[email protected]> Lukasz Luba <[email protected]> <[email protected]> diff --git a/MAINTAINERS b/MAINTAINERS index e83aee101b66..867157311dc8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1628,7 +1628,7 @@ N: meson ARM/Annapurna Labs ALPINE ARCHITECTURE M: Tsahee Zidenberg <[email protected]> -M: Antoine Tenart <[email protected]> +M: Antoine Tenart <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained F: arch/arm/boot/dts/alpine* @@ -7240,7 +7240,7 @@ F: drivers/staging/gasket/ GCC PLUGINS M: Kees Cook <[email protected]> R: Emese Revfy <[email protected]> S: Maintained F: Documentation/kbuild/gcc-plugins.rst F: scripts/Makefile.gcc-plugins @@ -8678,7 +8678,7 @@ F: drivers/input/input-mt.c K: \b(ABS|SYN)_MT_ INSIDE SECURE CRYPTO DRIVER -M: Antoine Tenart <[email protected]> +M: Antoine Tenart <[email protected]> S: Maintained F: drivers/crypto/inside-secure/ @@ -9802,7 +9802,7 @@ F: drivers/scsi/53c700* LEAKING_ADDRESSES M: Tobin C. Harding <[email protected]> M: Tycho Andersen <[email protected]> S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks.git F: scripts/leaking_addresses.pl diff --git a/include/linux/khugepaged.h b/include/linux/khugepaged.h index bc45ea1efbf7..c941b7377321 100644 --- a/include/linux/khugepaged.h +++ b/include/linux/khugepaged.h @@ -15,6 +15,7 @@ extern int __khugepaged_enter(struct mm_struct *mm); extern void __khugepaged_exit(struct mm_struct *mm); extern int khugepaged_enter_vma_merge(struct vm_area_struct *vma, unsigned long vm_flags); +extern void khugepaged_min_free_kbytes_update(void); #ifdef CONFIG_SHMEM extern void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr); #else @@ -85,6 +86,10 @@ static inline void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr) { } + +static inline void khugepaged_min_free_kbytes_update(void) +{ +} #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif /* _LINUX_KHUGEPAGED_H */ diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 7de11dcd534d..434c9c34aeb6 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -54,7 +54,8 @@ static inline void mapping_set_error(struct address_space *mapping, int error) __filemap_set_wb_err(mapping, error); /* Record it in superblock */ - errseq_set(&mapping->host->i_sb->s_wb_err, error); + if (mapping->host) + errseq_set(&mapping->host->i_sb->s_wb_err, error); /* Record it in flags for now, for legacy callers */ if (error == -ENOSPC) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 3a494cfa56d2..58b0d9c502a1 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -56,6 +56,9 @@ enum scan_result { #define CREATE_TRACE_POINTS #include <trace/events/huge_memory.h> +static struct task_struct *khugepaged_thread __read_mostly; +static DEFINE_MUTEX(khugepaged_mutex); + /* default scan 8*512 pte (or vmas) every 30 second */ static unsigned int khugepaged_pages_to_scan __read_mostly; static unsigned int khugepaged_pages_collapsed; @@ -2304,8 +2307,6 @@ static void set_recommended_min_free_kbytes(void) int start_stop_khugepaged(void) { - static struct task_struct *khugepaged_thread __read_mostly; - static DEFINE_MUTEX(khugepaged_mutex); int err = 0; mutex_lock(&khugepaged_mutex); @@ -2332,3 +2333,11 @@ fail: mutex_unlock(&khugepaged_mutex); return err; } + +void khugepaged_min_free_kbytes_update(void) +{ + mutex_lock(&khugepaged_mutex); + if (khugepaged_enabled() && khugepaged_thread) + set_recommended_min_free_kbytes(); + mutex_unlock(&khugepaged_mutex); +} diff --git a/mm/mmap.c b/mm/mmap.c index 40248d84ad5f..bdd19f5b994e 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1781,7 +1781,11 @@ unsigned long mmap_region(struct file *file, unsigned long addr, merge = vma_merge(mm, prev, vma->vm_start, vma->vm_end, vma->vm_flags, NULL, vma->vm_file, vma->vm_pgoff, NULL, NULL_VM_UFFD_CTX); if (merge) { - fput(file); + /* ->mmap() can change vma->vm_file and fput the original file. So + * fput the vma->vm_file here or we would add an extra fput for file + * and cause general protection fault ultimately. + */ + fput(vma->vm_file); vm_area_free(vma); vma = merge; /* Update vm_flags and possible addr to pick up the change. We don't diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6866533de8e6..780c8f023b28 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -69,6 +69,7 @@ #include <linux/nmi.h> #include <linux/psi.h> #include <linux/padata.h> +#include <linux/khugepaged.h> #include <asm/sections.h> #include <asm/tlbflush.h> @@ -7904,6 +7905,8 @@ int __meminit init_per_zone_wmark_min(void) setup_min_slab_ratio(); #endif + khugepaged_min_free_kbytes_update(); + return 0; } postcore_initcall(init_per_zone_wmark_min) |