diff options
| author | Daniel Vetter <[email protected]> | 2014-04-11 14:12:10 +0200 |
|---|---|---|
| committer | Daniel Vetter <[email protected]> | 2014-04-22 11:19:09 +0200 |
| commit | 3c858a33858baa8c55fbb1a2822b086b26424bb8 (patch) | |
| tree | 324c68f245380ad8b7899c28df38c84a359a3e47 | |
| parent | c10dddc1d5055467f67d50724f5297fe23b69cc2 (diff) | |
drm/plane_helper: don't disable plane in destroy function
By the time drm_mode_config_cleanup calls this all the hw state should
be cleaned up already - we even have a WARN right before calling
plane->destroy callbacks asserting that all framebuffers are gone.
So trying to disable things harder is a bit a bug. Caught by Thierry
since it resulted in some mode_config.mutex locking backtraces.
Cc: Thierry Reding <[email protected]>
Cc: Matt Roper <[email protected]>
Reviewed-by: Thierry Reding <[email protected]>
Tested-by: Thierry Reding <[email protected]>
Reviewed-by: Matt Roper <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/drm_plane_helper.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index f48566445c31..9540ff9f97fe 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -234,7 +234,6 @@ EXPORT_SYMBOL(drm_primary_helper_disable); */ void drm_primary_helper_destroy(struct drm_plane *plane) { - plane->funcs->disable_plane(plane); drm_plane_cleanup(plane); kfree(plane); } |