diff options
| author | Colin Cross <[email protected]> | 2012-05-07 17:57:40 -0700 |
|---|---|---|
| committer | Len Brown <[email protected]> | 2012-06-02 00:48:49 -0400 |
| commit | 3af272ab75c7a0c7fa5ae5507724d961f7e7718b (patch) | |
| tree | 114bbb6881afbefa2108038083cdd6216dc53c6c | |
| parent | 56cfbf74a17c40f3a741398103c9f5d5a6806715 (diff) | |
cpuidle: fix error handling in __cpuidle_register_device
Fix the error handling in __cpuidle_register_device to include
the missing list_del. Move it to a label, which will simplify
the error handling when coupled states are added.
Reviewed-by: Santosh Shilimkar <[email protected]>
Tested-by: Santosh Shilimkar <[email protected]>
Reviewed-by: Kevin Hilman <[email protected]>
Tested-by: Kevin Hilman <[email protected]>
Signed-off-by: Colin Cross <[email protected]>
Reviewed-by: Rafael J. Wysocki <[email protected]>
Signed-off-by: Len Brown <[email protected]>
| -rw-r--r-- | drivers/cpuidle/cpuidle.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index 3e3e3e4d9581..4540672a2e1c 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -403,13 +403,18 @@ static int __cpuidle_register_device(struct cpuidle_device *dev) per_cpu(cpuidle_devices, dev->cpu) = dev; list_add(&dev->device_list, &cpuidle_detected_devices); - if ((ret = cpuidle_add_sysfs(cpu_dev))) { - module_put(cpuidle_driver->owner); - return ret; - } + ret = cpuidle_add_sysfs(cpu_dev); + if (ret) + goto err_sysfs; dev->registered = 1; return 0; + +err_sysfs: + list_del(&dev->device_list); + per_cpu(cpuidle_devices, dev->cpu) = NULL; + module_put(cpuidle_driver->owner); + return ret; } /** |