aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek Vasut <[email protected]>2022-04-17 04:08:00 +0200
committerMarek Vasut <[email protected]>2022-04-26 00:01:56 +0200
commit3604f1e5319bb1a284cc8d600d89dc0cc3bc8ed8 (patch)
treef75e170e4e549f43d9270e0fceea6b22ecb1bad7
parent268a06e1dc82ef8de2251690cb84bacbbb58b376 (diff)
drm: mxsfb: Reorder mxsfb_crtc_mode_set_nofb()
Reorder mxsfb_crtc_mode_set_nofb() such that all functions which perform register IO are called from one single location in this function. This is a clean up. No functional change. Reviewed-by: Lucas Stach <[email protected]> Signed-off-by: Marek Vasut <[email protected]> Cc: Alexander Stein <[email protected]> Cc: Laurent Pinchart <[email protected]> Cc: Lucas Stach <[email protected]> Cc: Peng Fan <[email protected]> Cc: Robby Cai <[email protected]> Cc: Sam Ravnborg <[email protected]> Cc: Stefan Agner <[email protected]> Acked-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
-rw-r--r--drivers/gpu/drm/mxsfb/mxsfb_kms.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index 1f0f08eab8e7..b7c70d269d2c 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
@@ -282,15 +282,6 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb,
u32 bus_flags = mxsfb->connector->display_info.bus_flags;
int err;
- /* Mandatory eLCDIF reset as per the Reference Manual */
- err = mxsfb_reset_block(mxsfb);
- if (err)
- return;
-
- mxsfb_set_formats(mxsfb, bus_format);
-
- clk_set_rate(mxsfb->clk, m->crtc_clock * 1000);
-
if (mxsfb->bridge && mxsfb->bridge->timings)
bus_flags = mxsfb->bridge->timings->input_bus_flags;
@@ -301,6 +292,15 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb,
bus_flags);
DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags);
+ /* Mandatory eLCDIF reset as per the Reference Manual */
+ err = mxsfb_reset_block(mxsfb);
+ if (err)
+ return;
+
+ mxsfb_set_formats(mxsfb, bus_format);
+
+ clk_set_rate(mxsfb->clk, m->crtc_clock * 1000);
+
mxsfb_set_mode(mxsfb, bus_flags);
}