aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDeepak R Varma <[email protected]>2023-03-02 01:18:06 +0530
committerThierry Reding <[email protected]>2023-04-04 18:04:57 +0200
commit3105e42c75e0f80a6933e29291a94f669b869dbd (patch)
tree960c8abc144675e41e7e9cdf429a2a13182badfd
parent13fcbcb97d05be14c5ada46b5b6cf71f8c96ad50 (diff)
drm/tegra: sor: Remove redundant error logging
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified using platform_get_irq.cocci coccicheck script. Signed-off-by: Deepak R Varma <[email protected]> Reviewed-by: Ashutosh Dixit <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
-rw-r--r--drivers/gpu/drm/tegra/sor.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index e617d55f6f3c..8eafbdd3620c 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
}
err = platform_get_irq(pdev, 0);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+ if (err < 0)
goto remove;
- }
sor->irq = err;