diff options
| author | Vineeth Vijayan <[email protected]> | 2021-04-23 12:08:43 +0200 |
|---|---|---|
| committer | Heiko Carstens <[email protected]> | 2021-04-30 17:17:01 +0200 |
| commit | 2f7484fd73729f89085fe08d683f5a8d9e17fe99 (patch) | |
| tree | 4ebce413ab7c7b977d24633051e65edfa8a26946 | |
| parent | b0583ab47788617c6af484a844f13c57d7567c2a (diff) | |
s390/cio: remove invalid condition on IO_SCH_UNREG
The condition to check the cdev pointer validity on
css_sch_device_unregister() is a leftover from the 'commit 8cc0dcfdc1c0
("s390/cio: remove pm support from ccw bus driver")'. This could lead to a
situation, where detaching the device is not happening completely. Remove
this invalid condition in the IO_SCH_UNREG case.
Link: https://lore.kernel.org/r/[email protected]
Fixes: 8cc0dcfdc1c0 ("s390/cio: remove pm support from ccw bus driver")
Reported-by: Christian Ehrhardt <[email protected]>
Suggested-by: Christian Ehrhardt <[email protected]>
Cc: <[email protected]>
Signed-off-by: Vineeth Vijayan <[email protected]>
Tested-by: Julian Wiedmann <[email protected]>
Reviewed-by: Peter Oberparleiter <[email protected]>
Tested-by: Christian Ehrhardt <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
| -rw-r--r-- | drivers/s390/cio/device.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c index 3f026021e95e..84f659cafe76 100644 --- a/drivers/s390/cio/device.c +++ b/drivers/s390/cio/device.c @@ -1532,8 +1532,7 @@ static int io_subchannel_sch_event(struct subchannel *sch, int process) switch (action) { case IO_SCH_ORPH_UNREG: case IO_SCH_UNREG: - if (!cdev) - css_sch_device_unregister(sch); + css_sch_device_unregister(sch); break; case IO_SCH_ORPH_ATTACH: case IO_SCH_UNREG_ATTACH: |