aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Changzhong <[email protected]>2020-12-04 16:43:30 +0800
committerMichael S. Tsirkin <[email protected]>2020-12-18 16:14:31 -0500
commit2e1139d613c7fb0956e82f72a8281c0a475ad4f8 (patch)
tree10873fb3840ed14a21eaf1638619e5f8cf26cb7b
parente152d8af4220a05c9797591609151d404866beaa (diff)
vhost scsi: fix error return code in vhost_scsi_set_endpoint()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhang Changzhong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Michael S. Tsirkin <[email protected]>
-rw-r--r--drivers/vhost/scsi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 6ff8a5096691..4ce9f00ae10e 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
if (!vhost_vq_is_setup(vq))
continue;
- if (vhost_scsi_setup_vq_cmds(vq, vq->num))
+ ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
+ if (ret)
goto destroy_vq_cmds;
}