aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPetr Matousek <[email protected]>2015-03-11 12:16:09 +0100
committerPaolo Bonzini <[email protected]>2015-03-30 16:40:07 +0200
commit2dccb4cdbf8fd4cb1d779a6f7ddd66d193bb5805 (patch)
treefa2ca1d0b2df5ac8e31a1bc1c47be2673cce15eb
parent65844bb0a7861eefa3ce44cd788163ecc4e14f2d (diff)
kvm: x86: i8259: return initialized data on invalid-size read
If data is read from PIC with invalid access size, the return data stays uninitialized even though success is returned. Fix this by always initializing the data. Signed-off-by: Petr Matousek <[email protected]> Reported-by: Nadav Amit <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
-rw-r--r--arch/x86/kvm/i8259.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index cc31f7c06d3d..9541ba34126b 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s,
return -EOPNOTSUPP;
if (len != 1) {
+ memset(val, 0, len);
pr_pic_unimpl("non byte read\n");
return 0;
}