diff options
| author | Xie Yongji <[email protected]> | 2021-07-15 16:00:23 +0800 |
|---|---|---|
| committer | Michael S. Tsirkin <[email protected]> | 2021-08-11 06:44:23 -0400 |
| commit | 2b847f21145d84e2e1dde99d3e2c00a5468f02e4 (patch) | |
| tree | 90319556ead9a57ca98dd396845fc51910d3c77e | |
| parent | f7ad318ea0ad58ebe0e595e59aed270bb643b29b (diff) | |
vdpa_sim: Fix return value check for vdpa_alloc_device()
The vdpa_alloc_device() returns an error pointer upon
failure, not NULL. To handle the failure correctly, this
replaces NULL check with IS_ERR() check and propagate the
error upwards.
Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Xie Yongji <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefano Garzarella <[email protected]>
| -rw-r--r-- | drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index 14e024de5cbf..c621cf7feec0 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr) vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops, dev_attr->name); - if (!vdpasim) + if (IS_ERR(vdpasim)) { + ret = PTR_ERR(vdpasim); goto err_alloc; + } vdpasim->dev_attr = *dev_attr; INIT_WORK(&vdpasim->work, dev_attr->work_fn); |