aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRandy Dunlap <[email protected]>2023-02-25 21:39:46 -0800
committerCorey Minyard <[email protected]>2023-03-02 16:14:15 -0600
commit2a587b9ad052e7e92e508aea90c1e2ae433c1908 (patch)
treeedda387ff0cf556266a819a12f14f0ee5208e095
parent982818426a0ffaf93b0621826ed39a84be3d7d62 (diff)
ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP_MMIO" to "select REGMAP_MMIO", which will also set REGMAP. Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access") Signed-off-by: Randy Dunlap <[email protected]> Cc: Andrew Jeffery <[email protected]> Cc: Corey Minyard <[email protected]> Cc: [email protected] Cc: Arnd Bergmann <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
-rw-r--r--drivers/char/ipmi/Kconfig3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index b6c0d35fc1a5..f4adc6feb3b2 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO
config ASPEED_BT_IPMI_BMC
depends on ARCH_ASPEED || COMPILE_TEST
- depends on REGMAP && REGMAP_MMIO && MFD_SYSCON
+ depends on MFD_SYSCON
+ select REGMAP_MMIO
tristate "BT IPMI bmc driver"
help
Provides a driver for the BT (Block Transfer) IPMI interface