diff options
| author | Mario Limonciello <[email protected]> | 2023-06-23 10:05:19 -0500 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2023-06-30 13:11:36 -0400 |
| commit | 274d205cb59f43815542e04b42a9e6d0b9b95eff (patch) | |
| tree | 62f81bb1a890cdb3eb4b5bbba98072c638b47d61 | |
| parent | cfc7d8314b7e8fd6bcafa31deaa21ac9ad19494f (diff) | |
drm/amd/display: Correct `DMUB_FW_VERSION` macro
The `DMUB_FW_VERSION` macro has a mistake in that the revision field
is off by one byte. The last byte is typically used for other purposes
and not a revision.
Cc: [email protected]
Cc: Sean Wang <[email protected]>
Cc: Marc Rossi <[email protected]>
Cc: Hamza Mahfooz <[email protected]>
Cc: Tsung-hua (Ryan) Lin <[email protected]>
Reviewed-by: Leo Li <[email protected]>
Signed-off-by: Mario Limonciello <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/dmub_srv.h index 7c9a2b34bd05..2a66a305679a 100644 --- a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h +++ b/drivers/gpu/drm/amd/display/dmub/dmub_srv.h @@ -492,7 +492,7 @@ struct dmub_notification { * of a firmware to know if feature or functionality is supported or present. */ #define DMUB_FW_VERSION(major, minor, revision) \ - ((((major) & 0xFF) << 24) | (((minor) & 0xFF) << 16) | ((revision) & 0xFFFF)) + ((((major) & 0xFF) << 24) | (((minor) & 0xFF) << 16) | (((revision) & 0xFF) << 8)) /** * dmub_srv_create() - creates the DMUB service. |