aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMina Almasry <[email protected]>2024-09-13 06:07:45 +0000
committerJakub Kicinski <[email protected]>2024-09-13 11:41:45 -0700
commit26d7460222a0be34ff61a92a1fcc4469797ad937 (patch)
treef49a295428a9d100c164dead489606e204c208bb
parentbdf2ba157eb7db4c7bc603fef001c10fa9444ee2 (diff)
memory-provider: disable building dmabuf mp on !CONFIG_PAGE_POOL
When CONFIG_TRACEPOINTS=y but CONFIG_PAGE_POOL=n, we end up with this build failure that is reported by the 0-day bot: ld: vmlinux.o: in function `mp_dmabuf_devmem_alloc_netmems': >> (.text+0xc37286): undefined reference to `__tracepoint_page_pool_state_hold' >> ld: (.text+0xc3729a): undefined reference to `__SCT__tp_func_page_pool_state_hold' >> ld: vmlinux.o:(__jump_table+0x10c48): undefined reference to `__tracepoint_page_pool_state_hold' >> ld: vmlinux.o:(.static_call_sites+0xb824): undefined reference to `__SCK__tp_func_page_pool_state_hold' The root cause is that in this configuration, traces are enabled but the page_pool specific trace_page_pool_state_hold is not registered. There is no reason to build the dmabuf memory provider when CONFIG_PAGE_POOL is not present, as it's really a provider to the page_pool. In fact the whole NET_DEVMEM is RX path-only at the moment, so we can make the entire config dependent on the PAGE_POOL. Note that this may need to be revisited after/while devmem TX is added, as devmem TX likely does not need CONFIG_PAGE_POOL. For now this build fix is sufficient. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Mina Almasry <[email protected]> Reviewed-by: Simon Horman <[email protected]> Tested-by: Simon Horman <[email protected]> # build-tested Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
-rw-r--r--net/Kconfig1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/Kconfig b/net/Kconfig
index 7574b066d7cd..a629f92dc86b 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -70,6 +70,7 @@ config NET_DEVMEM
def_bool y
depends on DMA_SHARED_BUFFER
depends on GENERIC_ALLOCATOR
+ depends on PAGE_POOL
menu "Networking options"