diff options
| author | Florian Eckert <[email protected]> | 2023-11-27 09:16:21 +0100 |
|---|---|---|
| committer | Lee Jones <[email protected]> | 2023-12-13 11:28:43 +0000 |
| commit | 25054b232681c286fca9c678854f56494d1352cc (patch) | |
| tree | 7a4b3b074432ff221c35dea0a21f694aacc87d02 | |
| parent | 736214b4b02adf8734206599e36e2081d47554a2 (diff) | |
leds: ledtrig-tty: Free allocated ttyname buffer on deactivate
The ttyname buffer for the ledtrig_tty_data struct is allocated in the
sysfs ttyname_store() function. This buffer must be released on trigger
deactivation. This was missing and is thus a memory leak.
While we are at it, the TTY handler in the ledtrig_tty_data struct should
also be returned in case of the trigger deactivation call.
Cc: [email protected]
Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
Signed-off-by: Florian Eckert <[email protected]>
Reviewed-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Greg Kroah-Hartman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
| -rw-r--r-- | drivers/leds/trigger/ledtrig-tty.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c index 8ae0d2d284af..3e69a7bde928 100644 --- a/drivers/leds/trigger/ledtrig-tty.c +++ b/drivers/leds/trigger/ledtrig-tty.c @@ -168,6 +168,10 @@ static void ledtrig_tty_deactivate(struct led_classdev *led_cdev) cancel_delayed_work_sync(&trigger_data->dwork); + kfree(trigger_data->ttyname); + tty_kref_put(trigger_data->tty); + trigger_data->tty = NULL; + kfree(trigger_data); } |