aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThorsten Blum <[email protected]>2024-07-10 20:57:44 +0200
committerKalle Valo <[email protected]>2024-08-01 17:59:20 +0300
commit215a19631d1125a2834b2ffe62b8de9a9e73d6a8 (patch)
treea20acad39a46635cded1dc03df4ba7b06f48aacb
parentaa0d7643c8dd1a0483189499ea2f9492d74f4970 (diff)
wifi: ath9k: Use swap() to improve ath9k_hw_get_nf_hist_mid()
Use the swap() macro to simplify the ath9k_hw_get_nf_hist_mid() function and improve its readability. Fixes the following Coccinelle/coccicheck warning reported by swap.cocci: WARNING opportunity for swap() Compile-tested only. Signed-off-by: Thorsten Blum <[email protected]> Acked-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://patch.msgid.link/[email protected]
-rw-r--r--drivers/net/wireless/ath/ath9k/calib.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
index fb270df75eb2..4b331c85509c 100644
--- a/drivers/net/wireless/ath/ath9k/calib.c
+++ b/drivers/net/wireless/ath/ath9k/calib.c
@@ -32,11 +32,8 @@ static int16_t ath9k_hw_get_nf_hist_mid(int16_t *nfCalBuffer)
for (i = 0; i < ATH9K_NF_CAL_HIST_MAX - 1; i++) {
for (j = 1; j < ATH9K_NF_CAL_HIST_MAX - i; j++) {
- if (sort[j] > sort[j - 1]) {
- nfval = sort[j];
- sort[j] = sort[j - 1];
- sort[j - 1] = nfval;
- }
+ if (sort[j] > sort[j - 1])
+ swap(sort[j], sort[j - 1]);
}
}
nfval = sort[(ATH9K_NF_CAL_HIST_MAX - 1) >> 1];