diff options
| author | Krzysztof Kozlowski <[email protected]> | 2023-06-25 18:28:11 +0200 |
|---|---|---|
| committer | Dmitry Torokhov <[email protected]> | 2023-07-07 16:54:29 -0700 |
| commit | 21142c1cb29048f536700b833be1b2806fff3ef7 (patch) | |
| tree | 51a4d1e6b3e74d29a3ce286344a88fa4213ceb71 | |
| parent | 17d981fa707ef6f212dda17d1ec64a4a360c91a7 (diff) | |
Input: silead - simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Hans de Goede <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
| -rw-r--r-- | drivers/input/touchscreen/silead.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c index 9e28f962e059..62f562ad5026 100644 --- a/drivers/input/touchscreen/silead.c +++ b/drivers/input/touchscreen/silead.c @@ -706,11 +706,9 @@ static int silead_ts_probe(struct i2c_client *client) /* Power GPIO pin */ data->gpio_power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW); - if (IS_ERR(data->gpio_power)) { - if (PTR_ERR(data->gpio_power) != -EPROBE_DEFER) - dev_err(dev, "Shutdown GPIO request failed\n"); - return PTR_ERR(data->gpio_power); - } + if (IS_ERR(data->gpio_power)) + return dev_err_probe(dev, PTR_ERR(data->gpio_power), + "Shutdown GPIO request failed\n"); error = silead_ts_setup(client); if (error) |