aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYue Hu <[email protected]>2019-05-13 17:18:14 -0700
committerLinus Torvalds <[email protected]>2019-05-14 09:47:47 -0700
commit1df3a339074e31db95c4790ea9236874b13ccd87 (patch)
tree808458ab7f0be8a13d34a4c259fd68d4c2e20a10
parent113b7dfd827175977ea71cc4a29c1ac24acb9fce (diff)
mm/cma.c: fix crash on CMA allocation if bitmap allocation fails
f022d8cb7ec7 ("mm: cma: Don't crash on allocation if CMA area can't be activated") fixes the crash issue when activation fails via setting cma->count as 0, same logic exists if bitmap allocation fails. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Yue Hu <[email protected]> Reviewed-by: Anshuman Khandual <[email protected]> Cc: Joonsoo Kim <[email protected]> Cc: Laura Abbott <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: Randy Dunlap <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
-rw-r--r--mm/cma.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/mm/cma.c b/mm/cma.c
index d72a02fb7759..5e36d7418031 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -106,8 +106,10 @@ static int __init cma_activate_area(struct cma *cma)
cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
- if (!cma->bitmap)
+ if (!cma->bitmap) {
+ cma->count = 0;
return -ENOMEM;
+ }
WARN_ON_ONCE(!pfn_valid(pfn));
zone = page_zone(pfn_to_page(pfn));