diff options
| author | José Expósito <[email protected]> | 2024-10-31 19:38:35 +0100 |
|---|---|---|
| committer | Louis Chauvet <[email protected]> | 2024-11-04 12:03:21 +0100 |
| commit | 1d43dddd7c38ea1aa93f78f7ee10087afb0a561f (patch) | |
| tree | 08c0b89cdeaf0c8c59572dd629d03f959731d6d6 | |
| parent | 89115aeecf38bfee3c5e79561b5c34a256e1a06a (diff) | |
drm/vkms: Drop unnecessary call to drm_crtc_cleanup()
CRTC creation uses drmm_crtc_init_with_planes(), which automatically
handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is
still present in the vkms_output_init() error path.
Fixes: 99cc528ebe92 ("drm/vkms: Use drmm_crtc_init_with_planes()")
Signed-off-by: José Expósito <[email protected]>
Reviewed-by: Maíra Canal <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Acked-by: Louis Chauvet <[email protected]>
Signed-off-by: Louis Chauvet <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/vkms/vkms_output.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c index 0a5a185aa0b0..25a99fde126c 100644 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ b/drivers/gpu/drm/vkms/vkms_output.c @@ -92,7 +92,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index) DRM_MODE_CONNECTOR_VIRTUAL); if (ret) { DRM_ERROR("Failed to init connector\n"); - goto err_connector; + return ret; } drm_connector_helper_add(connector, &vkms_conn_helper_funcs); @@ -131,8 +131,5 @@ err_attach: err_encoder: drm_connector_cleanup(connector); -err_connector: - drm_crtc_cleanup(crtc); - return ret; } |