diff options
| author | Nikolay Aleksandrov <[email protected]> | 2014-05-09 11:11:39 +0200 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2014-05-12 14:56:45 -0400 |
| commit | 1c3639005f48492e5f2d965779efd814e80f8b15 (patch) | |
| tree | 81f29a6e27ee90a6f4c2a446db9233c2b4d253eb | |
| parent | bbeb0eadcf9fe74fb2b9b1a6fea82cd538b1e556 (diff) | |
sfc: fix calling of free_irq with already free vector
If the sfc driver is in legacy interrupt mode (either explicitly by
using interrupt_mode module param or by falling back to it) it will
hit a warning at kernel/irq/manage.c because it will try to free an irq
which wasn't allocated by it in the first place because the MSI(X) irqs are
zero and it'll try to free them unconditionally. So fix it by checking if
we're in legacy mode and freeing the appropriate irqs.
CC: Zenghui Shi <[email protected]>
CC: Ben Hutchings <[email protected]>
CC: <[email protected]>
CC: Shradha Shah <[email protected]>
CC: David S. Miller <[email protected]>
Fixes: 1899c111a535 ("sfc: Fix IRQ cleanup in case of a probe failure")
Reported-by: Zenghui Shi <[email protected]>
Signed-off-by: Nikolay Aleksandrov <[email protected]>
Acked-by: Shradha Shah <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
| -rw-r--r-- | drivers/net/ethernet/sfc/nic.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/net/ethernet/sfc/nic.c b/drivers/net/ethernet/sfc/nic.c index 32d969e857f7..89b83e59e1dc 100644 --- a/drivers/net/ethernet/sfc/nic.c +++ b/drivers/net/ethernet/sfc/nic.c @@ -156,13 +156,15 @@ void efx_nic_fini_interrupt(struct efx_nic *efx) efx->net_dev->rx_cpu_rmap = NULL; #endif - /* Disable MSI/MSI-X interrupts */ - efx_for_each_channel(channel, efx) - free_irq(channel->irq, &efx->msi_context[channel->channel]); - - /* Disable legacy interrupt */ - if (efx->legacy_irq) + if (EFX_INT_MODE_USE_MSI(efx)) { + /* Disable MSI/MSI-X interrupts */ + efx_for_each_channel(channel, efx) + free_irq(channel->irq, + &efx->msi_context[channel->channel]); + } else { + /* Disable legacy interrupt */ free_irq(efx->legacy_irq, efx); + } } /* Register dump */ |