aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJules Maselbas <[email protected]>2018-03-29 15:43:01 +0100
committerIngo Molnar <[email protected]>2018-03-31 20:42:38 +0200
commit1b5d43cfb69759d8ef8d30469cea31d0c037aed5 (patch)
tree8845496f34fe5c69de448b1dd703d0d9bdc50d34
parentb5dbc28762fd3fd40ba76303be0c7f707826f982 (diff)
sched/cpufreq/schedutil: Fix error path mutex unlock
This patch prevents the 'global_tunables_lock' mutex from being unlocked before being locked. This mutex is not locked if the sugov_kthread_create() function fails. Signed-off-by: Jules Maselbas <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Cc: Chris Redpath <[email protected]> Cc: Dietmar Eggermann <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Mike Galbraith <[email protected]> Cc: Patrick Bellasi <[email protected]> Cc: Stephen Kyle <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: [email protected] Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
-rw-r--r--kernel/sched/cpufreq_schedutil.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 7936f548e071..617c6741c525 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -625,10 +625,9 @@ fail:
stop_kthread:
sugov_kthread_stop(sg_policy);
-
-free_sg_policy:
mutex_unlock(&global_tunables_lock);
+free_sg_policy:
sugov_policy_free(sg_policy);
disable_fast_switch: