diff options
| author | Vasily Averin <[email protected]> | 2020-01-23 12:05:10 +0300 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2020-01-25 02:30:46 -0500 |
| commit | 1a8e9cf40c9a6a2e40b1e924b13ed303aeea4418 (patch) | |
| tree | d62a68e60c0387ac45c79584ca8ec256e764123c | |
| parent | 17c51d836c19ecc58714fc671a914a47b6ae4db7 (diff) | |
jbd2_seq_info_next should increase position index
if seq_file .next fuction does not change position index,
read after some lseek can generate unexpected output.
Script below generates endless output
$ q=;while read -r r;do echo "$((++q)) $r";done </proc/fs/jbd2/DEV/info
https://bugzilla.kernel.org/show_bug.cgi?id=206283
Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
Cc: [email protected]
Signed-off-by: Vasily Averin <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
| -rw-r--r-- | fs/jbd2/journal.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 1c61491fd86f..5f9edb12f11a 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -982,6 +982,7 @@ static void *jbd2_seq_info_start(struct seq_file *seq, loff_t *pos) static void *jbd2_seq_info_next(struct seq_file *seq, void *v, loff_t *pos) { + (*pos)++; return NULL; } |