diff options
| author | Hans Verkuil <[email protected]> | 2018-01-30 03:50:01 -0500 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2018-01-30 07:23:04 -0500 |
| commit | 181a4a2d5a0a7b43cab08a70710d727e7764ccdd (patch) | |
| tree | ca8f34e7af1b3e852f527473ba181b2bcba196b2 | |
| parent | b2469c814fbc8f1f19676dd4912717b798df511e (diff) | |
media: v4l2-ioctl.c: don't copy back the result for -ENOTTY
If the ioctl returned -ENOTTY, then don't bother copying
back the result as there is no point.
Signed-off-by: Hans Verkuil <[email protected]>
Acked-by: Sakari Ailus <[email protected]>
Cc: <[email protected]> # for v4.15 and up
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
| -rw-r--r-- | drivers/media/v4l2-core/v4l2-ioctl.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index c7f6b65d3ad7..260288ca4f55 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -2900,8 +2900,11 @@ video_usercopy(struct file *file, unsigned int cmd, unsigned long arg, /* Handles IOCTL */ err = func(file, cmd, parg); - if (err == -ENOIOCTLCMD) + if (err == -ENOTTY || err == -ENOIOCTLCMD) { err = -ENOTTY; + goto out; + } + if (err == 0) { if (cmd == VIDIOC_DQBUF) trace_v4l2_dqbuf(video_devdata(file)->minor, parg); |