diff options
| author | Beau Belgrave <[email protected]> | 2022-02-24 10:16:37 -0800 |
|---|---|---|
| committer | Steven Rostedt (Google) <[email protected]> | 2022-03-10 17:41:18 -0500 |
| commit | 173c2049d12b441b498d6423276f5dd76b1e637b (patch) | |
| tree | bdaf00f8e1dc79f5c3c68612eb44ffa48efef2e4 | |
| parent | 9f8e5aee93ed2482638d577a56806b455084b595 (diff) | |
user_events: Fix potential uninitialized pointer while parsing field
Ensure name is initialized by default to NULL to prevent possible edge
cases that could lead to it being left uninitialized. Add an explicit
check for NULL name to ensure edge boundaries.
Link: https://lore.kernel.org/bpf/20220224105334.GA2248@kili/
Link: https://lore.kernel.org/linux-trace-devel/[email protected]
Signed-off-by: Beau Belgrave <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
| -rw-r--r-- | kernel/trace/trace_events_user.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index 2b5e9fdb63a0..9a6191a6a786 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -362,6 +362,8 @@ skip_next: *field++ = '\0'; depth++; parse: + name = NULL; + while ((part = strsep(&field, " ")) != NULL) { switch (depth++) { case FIELD_DEPTH_TYPE: @@ -382,7 +384,7 @@ parse: } } - if (depth < FIELD_DEPTH_SIZE) + if (depth < FIELD_DEPTH_SIZE || !name) return -EINVAL; if (depth == FIELD_DEPTH_SIZE) |