diff options
| author | Dave Jones <[email protected]> | 2014-04-07 15:39:15 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2014-04-07 16:36:10 -0700 |
| commit | 16caed319604609a5579df132fce362a456170d7 (patch) | |
| tree | 4957342fcb459c2821297167362616ed38ce202c | |
| parent | b06dd879f5db33c1d7f5ab516ea671627f99c0c9 (diff) | |
fault-injection: set bounds on what /proc/self/make-it-fail accepts.
/proc/self/make-it-fail is a boolean, but accepts any number, including
negative ones. Change variable to unsigned, and cap upper bound at 1.
[[email protected]: don't make make_it_fail unsigned]
Signed-off-by: Dave Jones <[email protected]>
Reviewed-by: Akinobu Mita <[email protected]>
Cc: David Rientjes <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
| -rw-r--r-- | fs/proc/base.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 8da60e768b42..6b7087e2e8fb 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1236,6 +1236,9 @@ static ssize_t proc_fault_inject_write(struct file * file, make_it_fail = simple_strtol(strstrip(buffer), &end, 0); if (*end) return -EINVAL; + if (make_it_fail < 0 || make_it_fail > 1) + return -EINVAL; + task = get_proc_task(file_inode(file)); if (!task) return -ESRCH; |