diff options
| author | Vaibhav Gupta <[email protected]> | 2020-07-27 22:59:37 +0530 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2020-07-28 17:29:29 +0100 |
| commit | 15b413d93ccd0d26c29f005df82c299c8f14cbd6 (patch) | |
| tree | b042308a1a3dc4bc17c42c062e5c5965a2c57f21 | |
| parent | aa9e862d7d5bcecd4dca9f39e8b684b93dd84ee7 (diff) | |
spi: spi-topcliff-pch: drop call to wakeup-disable
Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)
This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.
Fixes: f185bcc77980 ("spi: spi-topcliff-pch: use generic power management")
Reported-by: Andy Shevchenko <[email protected]>
Signed-off-by: Vaibhav Gupta <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | drivers/spi/spi-topcliff-pch.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index b103768f9009..6df2aeff2843 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev) dev_dbg(dev, "%s ENTRY\n", __func__); - device_wakeup_disable(dev); - /* set suspend status to false */ pd_dev_save->board_dat->suspend_sts = false; |