diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2024-06-07 06:32:04 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-06-11 07:25:03 -0700 |
| commit | 138d45d96758db803b50761297f3331c9170bc87 (patch) | |
| tree | b64b32e9c0c7c91808abcf53657cf7f8d73d5508 | |
| parent | 71ac69e08947a03925cbd5f7517cba358cda1eb3 (diff) | |
hwmon: (pmbus/max31827) Explain why enum chips must not start with 0
If a driver calls device_get_match_data(), the .data pointer in its id
data structures must not be NULL/0 because device_get_match_data()
returns NULL if an entry is not found. Explain that in a comment to avoid
confusion why this is required in this driver but not in other drivers.
Cc: Daniel Matyas <daniel.matyas@analog.com>
Acked-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/max31827.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c index 4d89b6a7060b..48e8f8ba4d05 100644 --- a/drivers/hwmon/max31827.c +++ b/drivers/hwmon/max31827.c @@ -47,6 +47,11 @@ #define MAX31827_M_DGR_TO_16_BIT(x) (((x) << 4) / 1000) #define MAX31827_DEVICE_ENABLE(x) ((x) ? 0xA : 0x0) +/* + * The enum passed in the .data pointer of struct of_device_id must + * start with a value != 0 since that is a requirement for using + * device_get_match_data(). + */ enum chips { max31827 = 1, max31828, max31829 }; enum max31827_cnv { |