diff options
| author | Luis Chamberlain <[email protected]> | 2021-09-17 11:22:15 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2021-10-05 16:26:49 +0200 |
| commit | 0f8d7ccc2eab3e2ef39e49002e23e9677896715a (patch) | |
| tree | ed70bbb01e0695a1d92f81be465390862707bb96 | |
| parent | 7c4fd90741b724b199089869262862542a8f026b (diff) | |
firmware_loader: add a sanity check for firmware_request_builtin()
Right now firmware_request_builtin() is used internally only
and so we have control over the callers. But if we want to expose
that API more broadly we should ensure the firmware pointer
is valid.
This doesn't fix any known issue, it just prepares us to later
expose this API to other users.
Signed-off-by: Luis Chamberlain <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/base/firmware_loader/main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index eb4085b92ad4..d95b5fe5f700 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -115,6 +115,9 @@ static bool firmware_request_builtin(struct firmware *fw, const char *name) { struct builtin_fw *b_fw; + if (!fw) + return false; + for (b_fw = __start_builtin_fw; b_fw != __end_builtin_fw; b_fw++) { if (strcmp(name, b_fw->name) == 0) { fw->size = b_fw->size; |