diff options
| author | Andrei Otcheretianski <[email protected]> | 2015-03-12 08:53:30 +0200 |
|---|---|---|
| committer | Johannes Berg <[email protected]> | 2015-03-16 09:35:59 +0100 |
| commit | 0f611d28fc2e13cfec64e1c544c16a086886805a (patch) | |
| tree | 56ccc0f5079ec4cf869b9692294eb7f3a4a31d8b | |
| parent | aa75ebc275b2a91b193654a177daf900ad6703f0 (diff) | |
mac80211: count interfaces correctly for combination checks
Since moving the interface combination checks to mac80211, it's
broken because it now only considers interfaces with an assigned
channel context, so for example any interface that isn't active
can still be up, which is clearly an issue; also, in particular
P2P-Device wdevs are an issue since they never have a chanctx.
Fix this by counting running interfaces instead the ones with a
channel context assigned.
Cc: [email protected] [3.16+]
Fixes: 73de86a38962b ("cfg80211/mac80211: move interface counting for combination check to mac80211")
Signed-off-by: Andrei Otcheretianski <[email protected]>
Signed-off-by: Emmanuel Grumbach <[email protected]>
[rewrite commit message, dig out the commit it fixes]
Signed-off-by: Johannes Berg <[email protected]>
| -rw-r--r-- | net/mac80211/util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/util.c b/net/mac80211/util.c index 8428f4a95479..747bdcf72e92 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c @@ -3178,7 +3178,7 @@ int ieee80211_check_combinations(struct ieee80211_sub_if_data *sdata, wdev_iter = &sdata_iter->wdev; if (sdata_iter == sdata || - rcu_access_pointer(sdata_iter->vif.chanctx_conf) == NULL || + !ieee80211_sdata_running(sdata_iter) || local->hw.wiphy->software_iftypes & BIT(wdev_iter->iftype)) continue; |