diff options
| author | Christophe JAILLET <[email protected]> | 2022-01-15 16:24:50 +0100 |
|---|---|---|
| committer | Jiri Kosina <[email protected]> | 2022-01-24 09:14:02 +0100 |
| commit | 0f203948230720e849ad50d158adac1cd32c282f (patch) | |
| tree | 7e5db7bbc7a81b5d13e13dccccf4138662663a24 | |
| parent | 9b57f458985742bd1c585f4c7f36d04634ce1143 (diff) | |
HID: amd_sfh: Remove useless DMA-32 fallback configuration
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lore.kernel.org/linux-kernel/[email protected]/#t
Signed-off-by: Christophe JAILLET <[email protected]>
Acked-by: Basavaraj Natikar <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
| -rw-r--r-- | drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c index 2503be0253d3..673536d1d9ba 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -248,11 +248,8 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i pci_set_master(pdev); rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (rc) { - rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (rc) { - dev_err(&pdev->dev, "failed to set DMA mask\n"); - return rc; - } + dev_err(&pdev->dev, "failed to set DMA mask\n"); + return rc; } privdata->cl_data = devm_kzalloc(&pdev->dev, sizeof(struct amdtp_cl_data), GFP_KERNEL); |