diff options
| author | Wei Yang <richard.weiyang@gmail.com> | 2024-06-10 14:37:42 +0000 |
|---|---|---|
| committer | Mike Rapoport (IBM) <rppt@kernel.org> | 2024-06-10 18:13:01 +0300 |
| commit | 0e9899feed9cbb7d33c01ad849dc307b1560b0ab (patch) | |
| tree | 07f7283d5fa6a1b3159c82cdba21ac907de72147 | |
| parent | f1180fd2a7c039691b64ebf404c746a74e40b7b0 (diff) | |
mm/mm_init.c: don't initialize page->lru again
Current page initialization call flow looks like this with some
simplification:
setup_arch()
paging_init()
free_area_init()
memmap_init()
memmap_init_zone_range()
memmap_init_range()
defer_init()
__init_single_page()
mm_core_init()
mem_init()
memblock_free_all()
free_low_memory_core_early()
memmap_init_reserved_pages()
reserve_bootmem_region()
init_reserved_page()
__init_single_page()
There two cases depends on CONFIG_DEFERRED_STRUCT_PAGE_INIT.
* If CONFIG_DEFERRED_STRUCT_PAGE_INIT, pages after first_init_pfn is
skipped at defer_init(). Then init_reserved_page() is defined to
call __init_single_page() for them.
* If !CONFIG_DEFERRED_STRUCT_PAGE_INIT, pages are all initialized by
memmap_init_range().
In both cases, after init_reserved_page(), we expect __init_single_page()
has done its work to the page, which already initialize page->lru properly.
We don't need to do it again.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Link: https://lore.kernel.org/r/20240610143742.26401-1-richard.weiyang@gmail.com
Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
| -rw-r--r-- | mm/mm_init.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/mm/mm_init.c b/mm/mm_init.c index 5a4c846393b7..ba993305e8c2 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -760,9 +760,6 @@ void __meminit reserve_bootmem_region(phys_addr_t start, init_reserved_page(start_pfn, nid); - /* Avoid false-positive PageTail() */ - INIT_LIST_HEAD(&page->lru); - /* * no need for atomic set_bit because the struct * page is not visible yet so nobody should |