diff options
| author | Paolo Valente <[email protected]> | 2018-01-09 10:27:59 +0100 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2018-01-09 08:45:25 -0700 |
| commit | 0d52af590552473666da5b6111e7182d6cd23f92 (patch) | |
| tree | e83a75df643ef3dd663e2b260328888ce9220d36 | |
| parent | 52257ffbfcaf58d247b13fb148e27ed17c33e526 (diff) | |
block, bfq: release oom-queue ref to root group on exit
On scheduler init, a reference to the root group, and a reference to
its corresponding blkg are taken for the oom queue. Yet these
references are not released on scheduler exit, which prevents these
objects from be freed. This commit adds the missing reference
releases.
Reported-by: Davide Ferrari <[email protected]>
Tested-by: Holger Hoffstätte <[email protected]>
Signed-off-by: Paolo Valente <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
| -rw-r--r-- | block/bfq-iosched.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 7bd789da7a29..7c0b7f60811c 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4893,6 +4893,9 @@ static void bfq_exit_queue(struct elevator_queue *e) hrtimer_cancel(&bfqd->idle_slice_timer); + /* release oom-queue reference to root group */ + bfqg_and_blkg_put(bfqd->root_group); + #ifdef CONFIG_BFQ_GROUP_IOSCHED blkcg_deactivate_policy(bfqd->queue, &blkcg_policy_bfq); #else |