diff options
| author | Andy Shevchenko <[email protected]> | 2023-11-30 16:32:06 +0200 |
|---|---|---|
| committer | Lee Jones <[email protected]> | 2023-12-07 13:50:30 +0000 |
| commit | 0c679fffd67605a2c10a61a9a09890970eae11a9 (patch) | |
| tree | adb10791f7ea07576a91a80703d9d7c72b37157e | |
| parent | 7a29fa05aeca2c16193f00a883c56ffc7c25b6c5 (diff) | |
mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
The pci_alloc_irq_vectors() returns a positive number on success.
Hence we have to filter the negative numbers for error condition.
Update the check accordingly.
Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
Reported-by: Heikki Krogerus <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Tested-by: Heikki Krogerus <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
| -rw-r--r-- | drivers/mfd/intel-lpss-pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index 8f5e10817a9c..4621d3950b8f 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c @@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev, return ret; ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY); - if (ret) + if (ret < 0) return ret; info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL); |