diff options
| author | Kang Minchul <[email protected]> | 2022-10-26 02:06:20 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-10-31 09:05:17 +0100 |
| commit | 0a7bf6a948b2a772ebed3915b6c47189d63dc246 (patch) | |
| tree | f12c66db90a8d900777923d7092b2e8753c73d8f | |
| parent | f67469fe658a484f8c000bfcf66a191417bd6e30 (diff) | |
staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit
Return 0 directly instead of storing it in a variable.
This can prevent cocci warning as follows:
Unneeded variable: "pull". Return "0" on line 298
Tested-by: Philipp Hortmann <[email protected]> # Edimax N150
Signed-off-by: Kang Minchul <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index 8e4a5acc0b18..6d1f56d1f9d7 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt) { - int pull = 0; uint qsel; u8 data_rate, pwr_status, offset; struct adapter *adapt = pxmitframe->padapter; @@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id); rtl8188eu_cal_txdesc_chksum(ptxdesc); - return pull; + return 0; } /* for non-agg data frame or management frame */ |