diff options
| author | Martin Kaiser <[email protected]> | 2021-12-26 20:55:43 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2021-12-28 17:12:34 +0100 |
| commit | 0a7a87c418f8fbbb124ccd5f032e358cfdb81dac (patch) | |
| tree | 2b7a6e6ecdf77b48b5caedb1aad8dbfdae154150 | |
| parent | 98731fa612476989063ebe3040d4ba9966965970 (diff) | |
staging: r8188eu: clean up blinking macros
Clean up the macros that check the blinking mode of a LED.
The macro IS_LED_BLINKING is not used and can be removed.
The IS_LED_WPS_BLINKING macro is used only by rtw_led.c. Move the macro
into this file. The macro parameter is always a struct LED_871x *,
there's no need for a cast. Rename the parameter to l and put it in
parentheses, which is good practice for macro parameters.
Signed-off-by: Martin Kaiser <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/staging/r8188eu/core/rtw_led.c | 5 | ||||
| -rw-r--r-- | drivers/staging/r8188eu/include/rtw_led.h | 9 |
2 files changed, 5 insertions, 9 deletions
diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c index 517aef664bfc..63b811cba277 100644 --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -5,6 +5,11 @@ #include "../include/rtw_led.h" #include "../include/rtl8188e_spec.h" +#define IS_LED_WPS_BLINKING(l) \ + ((l)->CurrLedState == LED_BLINK_WPS || \ + (l)->CurrLedState == LED_BLINK_WPS_STOP || \ + (l)->bLedWPSBlinkInProgress) + static void ResetLedStatus(struct LED_871x *pLed) { pLed->CurrLedState = RTW_LED_OFF; /* Current LED state. */ diff --git a/drivers/staging/r8188eu/include/rtw_led.h b/drivers/staging/r8188eu/include/rtw_led.h index cd9e40aa7c65..69656da76d19 100644 --- a/drivers/staging/r8188eu/include/rtw_led.h +++ b/drivers/staging/r8188eu/include/rtw_led.h @@ -74,15 +74,6 @@ struct LED_871x { struct delayed_work blink_work; }; -#define IS_LED_WPS_BLINKING(_LED_871x) \ - (((struct LED_871x *)_LED_871x)->CurrLedState == LED_BLINK_WPS || \ - ((struct LED_871x *)_LED_871x)->CurrLedState == LED_BLINK_WPS_STOP || \ - ((struct LED_871x *)_LED_871x)->bLedWPSBlinkInProgress) - -#define IS_LED_BLINKING(_LED_871x) \ - (((struct LED_871x *)_LED_871x)->bLedWPSBlinkInProgress || \ - ((struct LED_871x *)_LED_871x)->bLedScanBlinkInProgress) - void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE LedAction); struct led_priv{ |