diff options
| author | Jakub Kicinski <[email protected]> | 2023-05-24 10:07:12 -0700 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-05-25 21:02:43 -0700 |
| commit | 081e8df6819997eae236f75dd52f0c147c4be939 (patch) | |
| tree | 7c3a6a8e20904c1c955b385a1b2ddbeb8ccbf1d7 | |
| parent | 31642e7089df8fd3f54ca7843f7ee2952978cad1 (diff) | |
tools: ynl: avoid dict errors on older Python versions
Python 3.9.0 or newer supports combining dicts() with |,
but older versions of Python are still used in the wild
(e.g. on CentOS 8, which goes EoL May 31, 2024).
With Python 3.6.8 we get:
TypeError: unsupported operand type(s) for |: 'dict' and 'dict'
Use older syntax. Tested with non-legacy families only.
Fixes: f036d936ca57 ("tools: ynl: Add fixed-header support to ynl")
Reviewed-by: Simon Horman <[email protected]>
Reviewed-by: Donald Hunter <[email protected]>
Tested-by: Donald Hunter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
| -rw-r--r-- | tools/net/ynl/lib/ynl.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py index aa77bcae4807..3144f33196be 100644 --- a/tools/net/ynl/lib/ynl.py +++ b/tools/net/ynl/lib/ynl.py @@ -591,8 +591,9 @@ class YnlFamily(SpecFamily): print('Unexpected message: ' + repr(gm)) continue - rsp.append(self._decode(gm.raw_attrs, op.attr_set.name) - | gm.fixed_header_attrs) + rsp_msg = self._decode(gm.raw_attrs, op.attr_set.name) + rsp_msg.update(gm.fixed_header_attrs) + rsp.append(rsp_msg) if not rsp: return None |