aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohan Hovold <[email protected]>2021-11-17 11:05:10 +0100
committerGreg Kroah-Hartman <[email protected]>2021-11-25 18:25:49 +0100
commit05f929b395dec8957b636ff14e66b277ed022ed9 (patch)
tree536f70b0347e138ef0ddf38d8b3ac894e8e483c6
parent0f55f89d98c8b3e12b4f55f71c127a173e29557c (diff)
serial: liteuart: fix use-after-free and memleak on unbind
Deregister the port when unbinding the driver to prevent it from being used after releasing the driver data and leaking memory allocated by serial core. Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver") Cc: [email protected] # 5.11 Cc: Filip Kokosinski <[email protected]> Cc: Mateusz Holenko <[email protected]> Reviewed-by: Stafford Horne <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
-rw-r--r--drivers/tty/serial/liteuart.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index f075f4ff5fcf..da792d0df790 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -295,6 +295,7 @@ static int liteuart_remove(struct platform_device *pdev)
struct uart_port *port = platform_get_drvdata(pdev);
struct liteuart_port *uart = to_liteuart_port(port);
+ uart_remove_one_port(&liteuart_driver, port);
xa_erase(&liteuart_array, uart->id);
return 0;