diff options
| author | Ajye Huang <[email protected]> | 2023-01-08 01:59:33 +0800 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2023-01-09 13:05:32 +0000 |
| commit | 05d450b06d6a299bd5a7f209c81db681c3cdbcd9 (patch) | |
| tree | def36b450dcb43c500165399406ee71c9368ed0b | |
| parent | de1cae22898cf10aacc735a21d799b5bbce4496c (diff) | |
ASoC: mediatek: mt8186-rt5682: primary_codec_init() warn: missing error code? 'ret'
The function primary_codec_init() should return 0 if dmic_sel is null.
Here is the warning message reported by 0-DAY CI Kernel Test Service.
smatch warnings:
primary_codec_init() warn: missing error code? 'ret'
...
2022-11-02 141 if (!priv->dmic_sel) {
2022-11-02 142 dev_info(card->dev, "dmic_sel is null\n");
2022-11-02 @143 return ret;
return -EIVNAL;? return 0;?
2022-11-02 144 }
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Ajye Huang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c index 8f77a0bc1dc8..201101a7d6e2 100644 --- a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c +++ b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c @@ -140,7 +140,7 @@ static int primary_codec_init(struct snd_soc_pcm_runtime *rtd) if (!priv->dmic_sel) { dev_info(card->dev, "dmic_sel is null\n"); - return ret; + return 0; } ret = snd_soc_dapm_new_controls(&card->dapm, dmic_widgets, |