diff options
| author | Zhu Wang <[email protected]> | 2023-08-03 10:02:30 +0800 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2023-08-07 21:34:08 -0400 |
| commit | 04b5b5cb0136ce970333a9c6cec7e46adba1ea3a (patch) | |
| tree | e95c5f8a2dd01aebdbfc083853fe874bd21aa85c | |
| parent | 9426d3cef5000824e5f24f80ed5f42fb935f2488 (diff) | |
scsi: core: Fix possible memory leak if device_add() fails
If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to decrease the reference count in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().
Fixes: ee959b00c335 ("SCSI: convert struct class_device to struct device")
Signed-off-by: Zhu Wang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
| -rw-r--r-- | drivers/scsi/raid_class.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/raid_class.c b/drivers/scsi/raid_class.c index 898a0bdf8df6..711252e52d8e 100644 --- a/drivers/scsi/raid_class.c +++ b/drivers/scsi/raid_class.c @@ -248,6 +248,7 @@ int raid_component_add(struct raid_template *r,struct device *raid_dev, return 0; err_out: + put_device(&rc->dev); list_del(&rc->node); rd->component_count--; put_device(component_dev); |