diff options
| author | Siddharth Vadapalli <[email protected]> | 2024-08-27 17:54:21 +0530 |
|---|---|---|
| committer | Krzysztof Wilczyński <[email protected]> | 2024-09-13 21:34:38 +0000 |
| commit | 03f84b3baba7836bdfc162c19288d5ce1aa92890 (patch) | |
| tree | 4f7ef523c7898025dd06d8af753745afba14d6d3 | |
| parent | 8400291e289ee6b2bf9779ff1c83a291501f017b (diff) | |
PCI: dra7xx: Fix threaded IRQ request for "dra7xx-pcie-main" IRQ
Commit da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for
"dra7xx-pcie-main" IRQ") switched from devm_request_irq() to
devm_request_threaded_irq() for the "dra7xx-pcie-main" interrupt.
Since the primary handler was set to NULL, the "IRQF_ONESHOT" flag
should have also been set. Fix this.
Fixes: da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ")
Suggested-by: Vignesh Raghavendra <[email protected]>
Link: https://lore.kernel.org/linux-pci/[email protected]
Reported-by: Udit Kumar <[email protected]>
Signed-off-by: Siddharth Vadapalli <[email protected]>
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Reviewed-by: Kevin Hilman <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]
| -rw-r--r-- | drivers/pci/controller/dwc/pci-dra7xx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 4fe3b0cb72ec..20fb50741f3d 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -850,7 +850,8 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) dra7xx->mode = mode; ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler, - IRQF_SHARED, "dra7xx-pcie-main", dra7xx); + IRQF_SHARED | IRQF_ONESHOT, + "dra7xx-pcie-main", dra7xx); if (ret) { dev_err(dev, "failed to request irq\n"); goto err_gpio; |