diff options
| author | Wang Weiyang <[email protected]> | 2022-11-23 17:51:47 +0800 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2022-12-11 19:30:18 -0800 |
| commit | 02d7d89f816951e0862147d751b1150d67aaebdd (patch) | |
| tree | dd72db756eb91ca90bd08308936c1ef1c8d9626e | |
| parent | 3f0dad0105133ffcfa13eb0cd980fa347bcf31d7 (diff) | |
rapidio: fix possible UAF when kfifo_alloc() fails
If kfifo_alloc() fails in mport_cdev_open(), goto err_fifo and just free
priv. But priv is still in the chdev->file_list, then list traversal
may cause UAF. This fixes the following smatch warning:
drivers/rapidio/devices/rio_mport_cdev.c:1930 mport_cdev_open() warn: '&priv->list' not removed from list
Link: https://lkml.kernel.org/r/[email protected]
Fixes: e8de370188d0 ("rapidio: add mport char device driver")
Signed-off-by: Wang Weiyang <[email protected]>
Cc: Alexandre Bounine <[email protected]>
Cc: Dan Carpenter <[email protected]>
Cc: Jakob Koschel <[email protected]>
Cc: John Hubbard <[email protected]>
Cc: Matt Porter <[email protected]>
Cc: Yang Yingliang <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
| -rw-r--r-- | drivers/rapidio/devices/rio_mport_cdev.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c index 3cc83997a1f8..fecf523f36d8 100644 --- a/drivers/rapidio/devices/rio_mport_cdev.c +++ b/drivers/rapidio/devices/rio_mport_cdev.c @@ -1904,10 +1904,6 @@ static int mport_cdev_open(struct inode *inode, struct file *filp) priv->md = chdev; - mutex_lock(&chdev->file_mutex); - list_add_tail(&priv->list, &chdev->file_list); - mutex_unlock(&chdev->file_mutex); - INIT_LIST_HEAD(&priv->db_filters); INIT_LIST_HEAD(&priv->pw_filters); spin_lock_init(&priv->fifo_lock); @@ -1926,6 +1922,9 @@ static int mport_cdev_open(struct inode *inode, struct file *filp) spin_lock_init(&priv->req_lock); mutex_init(&priv->dma_lock); #endif + mutex_lock(&chdev->file_mutex); + list_add_tail(&priv->list, &chdev->file_list); + mutex_unlock(&chdev->file_mutex); filp->private_data = priv; goto out; |