diff options
author | Daniel Lezcano <daniel.lezcano@linaro.org> | 2020-03-21 20:31:07 +0100 |
---|---|---|
committer | Daniel Lezcano <daniel.lezcano@linaro.org> | 2020-03-23 15:20:47 +0100 |
commit | 40ea568593f20647e7d58deb7fcfa69b11a37d8b (patch) | |
tree | bafe1406cb9984cf802bd80e4731ea4c806f7026 /.get_maintainer.ignore | |
parent | ff44f672d74178b3be19d41a169b98b3e391d4ce (diff) |
thermal/drivers/cpufreq_cooling: Remove abusing WARN_ON
The WARN_ON macros are used at the entry functions state2power() and
set_cur_state().
state2power() is called with the max_state retrieved from
get_max_state which returns cpufreq_cdev->max_level, then it check if
max_state is > cpufreq_cdev->max_level. The test does not really makes
sense but let's assume we want to make sure to catch an error if the
code evolves. However the WARN_ON is overkill.
set_cur_state() is also called from userspace if we write to the
sysfs. It is easy to see a stack dumped by just writing to sysfs
/sys/class/thermal/cooling_device0/cur_state a value greater than
"max_level". A bit scary. Returing -EINVAL is enough.
Remove these WARN_ON.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20200321193107.21590-1-daniel.lezcano@linaro.org
Diffstat (limited to '.get_maintainer.ignore')
0 files changed, 0 insertions, 0 deletions