aboutsummaryrefslogtreecommitdiff
path: root/hid-magicmouse.c
diff options
context:
space:
mode:
authorBlaster4385 <[email protected]>2026-11-22 13:29:37 +0530
committerBlaster4385 <[email protected]>2026-11-22 13:56:46 +0530
commit30cd4cb3e64c81230477eb991728a82f8430c8f3 (patch)
tree800d200a88185e8071c2bf270ce38b1d067452a8 /hid-magicmouse.c
parent5fbe811338885525f553c0116f6a46b715a66b38 (diff)
cancel left click when force replaces itHEADmain
Diffstat (limited to 'hid-magicmouse.c')
-rw-r--r--hid-magicmouse.c111
1 files changed, 105 insertions, 6 deletions
diff --git a/hid-magicmouse.c b/hid-magicmouse.c
index 5fa8449..434b70f 100644
--- a/hid-magicmouse.c
+++ b/hid-magicmouse.c
@@ -97,6 +97,7 @@ MODULE_PARM_DESC(report_undeciphered, "Report undeciphered multi-touch state fie
#define FORCE_STAGE2_PRESS 165
#define FORCE_STAGE2_RELEASE 125
#define FORCE_DEBOUNCE_MS 15
+#define FORCE_PENDING_LEFT_MOTION 30
/* Feedback is 0x00SSDDHH. */
#define FORCE_FEEDBACK_CLICK 0x060617
@@ -220,6 +221,9 @@ struct magicmouse_sc {
bool force_ready;
bool btn_left_forced;
bool force_key_down;
+ bool pending_left;
+ int pending_left_x;
+ int pending_left_y;
struct input_dev *force_input;
bool is_bt;
bool is_actuator;
@@ -1238,6 +1242,80 @@ static void magicmouse_set_button(struct input_dev *input, unsigned int code,
input_report_key(input, code, down);
}
+static bool magicmouse_force_exclusive(void)
+{
+ return force_button != FORCE_KEY;
+}
+
+static void magicmouse_primary_touch(struct magicmouse_sc *msc, int *x, int *y)
+{
+ int i;
+
+ *x = 0;
+ *y = 0;
+ for (i = 0; i < 16; i++) {
+ if (!msc->touches[i].down)
+ continue;
+ *x = msc->touches[i].x;
+ *y = msc->touches[i].y;
+ return;
+ }
+}
+
+static void magicmouse_set_left(struct magicmouse_sc *msc, bool down)
+{
+ if (!msc->input)
+ return;
+
+ magicmouse_set_button(msc->input, BTN_MOUSE, &msc->btn_left_forced,
+ down);
+}
+
+static void magicmouse_start_pending_left(struct magicmouse_sc *msc)
+{
+ msc->pending_left = true;
+ magicmouse_primary_touch(msc, &msc->pending_left_x,
+ &msc->pending_left_y);
+}
+
+static void magicmouse_commit_pending_left(struct magicmouse_sc *msc)
+{
+ if (!msc->pending_left)
+ return;
+
+ msc->pending_left = false;
+ magicmouse_set_left(msc, true);
+}
+
+static void magicmouse_cancel_pending_left(struct magicmouse_sc *msc)
+{
+ msc->pending_left = false;
+}
+
+static void magicmouse_click_pending_left(struct magicmouse_sc *msc)
+{
+ if (!msc->pending_left)
+ return;
+
+ msc->pending_left = false;
+ magicmouse_set_left(msc, true);
+ input_sync(msc->input);
+ magicmouse_set_left(msc, false);
+}
+
+static void magicmouse_update_pending_left(struct magicmouse_sc *msc)
+{
+ int x, y;
+
+ if (!msc->pending_left)
+ return;
+
+ magicmouse_primary_touch(msc, &x, &y);
+ if (abs(x - msc->pending_left_x) > FORCE_PENDING_LEFT_MOTION ||
+ abs(y - msc->pending_left_y) > FORCE_PENDING_LEFT_MOTION)
+ magicmouse_commit_pending_left(msc);
+}
+
static void magicmouse_force_key(struct magicmouse_sc *msc, bool down)
{
if (!msc->force_input) {
@@ -1255,7 +1333,8 @@ static void magicmouse_force_release(struct magicmouse_sc *msc)
if (!msc->input || msc->force_stage == FORCE_STAGE_NONE)
return;
- magicmouse_set_button(msc->input, BTN_MOUSE, &msc->btn_left_forced, false);
+ magicmouse_cancel_pending_left(msc);
+ magicmouse_set_left(msc, false);
magicmouse_force_key(msc, false);
input_event(msc->input, EV_MSC, MSC_RAW, 0);
input_sync(msc->input);
@@ -1274,18 +1353,25 @@ static void magicmouse_force_emit_stage(struct magicmouse_sc *msc,
return;
if (old == FORCE_STAGE_NONE && stage >= FORCE_STAGE_CLICK) {
- if (msc->force_ready)
- magicmouse_set_button(input, BTN_MOUSE,
- &msc->btn_left_forced, true);
+ if (msc->force_ready) {
+ if (magicmouse_force_exclusive())
+ magicmouse_start_pending_left(msc);
+ else
+ magicmouse_set_left(msc, true);
+ }
magicmouse_queue_haptic(msc, FORCE_FEEDBACK_CLICK);
input_event(input, EV_MSC, MSC_RAW, 1);
} else if (old >= FORCE_STAGE_CLICK && stage == FORCE_STAGE_NONE) {
- magicmouse_set_button(input, BTN_MOUSE, &msc->btn_left_forced, false);
+ if (magicmouse_force_exclusive() && msc->pending_left)
+ magicmouse_click_pending_left(msc);
+ else
+ magicmouse_set_left(msc, false);
magicmouse_queue_haptic(msc, FORCE_FEEDBACK_RELEASE);
input_event(input, EV_MSC, MSC_RAW, 0);
}
if (old < FORCE_STAGE_FORCE && stage == FORCE_STAGE_FORCE) {
+ magicmouse_cancel_pending_left(msc);
magicmouse_force_key(msc, true);
magicmouse_queue_haptic(msc, FORCE_FEEDBACK_FORCE);
input_event(input, EV_MSC, MSC_RAW, 2);
@@ -1307,6 +1393,9 @@ static void magicmouse_force_update(struct magicmouse_sc *msc, u8 pressure)
return;
}
+ if (magicmouse_force_exclusive() && msc->force_stage == FORCE_STAGE_CLICK)
+ magicmouse_update_pending_left(msc);
+
switch (msc->force_stage) {
case FORCE_STAGE_NONE:
cand = pressure >= FORCE_STAGE1_PRESS ?
@@ -1410,6 +1499,7 @@ static int magicmouse_set_force_button(const char *val,
{
struct magicmouse_sc *msc;
unsigned int button;
+ bool exclusive;
int ret = kstrtouint(val, 0, &button);
if (ret)
@@ -1419,9 +1509,18 @@ static int magicmouse_set_force_button(const char *val,
if (force_button == button)
return 0;
+ exclusive = button != FORCE_KEY;
+
mutex_lock(&magicmouse_actuator_lock);
- list_for_each_entry(msc, &magicmouse_trackpads, node)
+ list_for_each_entry(msc, &magicmouse_trackpads, node) {
+ if (exclusive) {
+ magicmouse_cancel_pending_left(msc);
+ magicmouse_set_left(msc, false);
+ } else if (msc->pending_left) {
+ magicmouse_commit_pending_left(msc);
+ }
magicmouse_force_key(msc, false);
+ }
force_button = button;
mutex_unlock(&magicmouse_actuator_lock);