From fe108210fa0a3846dbb800cfb07ff8e2fc445efa Mon Sep 17 00:00:00 2001
From: Blaster4385 <blaster4385@tablaster.dev>
Date: Mon, 19 Feb 2024 20:43:06 +0530
Subject: refactor: Optimize Editor and Header

---
 client/src/components/Editor/Editor.jsx        | 39 +++++++++++++-------------
 client/src/components/Editor/Editor.module.css |  6 ++--
 client/src/components/Header/Header.jsx        |  1 -
 3 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/client/src/components/Editor/Editor.jsx b/client/src/components/Editor/Editor.jsx
index c291872..143abd3 100644
--- a/client/src/components/Editor/Editor.jsx
+++ b/client/src/components/Editor/Editor.jsx
@@ -1,4 +1,4 @@
-import { useState, useEffect, useRef } from "react";
+import React, { useState, useEffect, useRef, useMemo } from "react";
 import { useNavigate, useParams } from "react-router-dom";
 import Prism from "prismjs";
 import styles from "./Editor.module.css";
@@ -6,8 +6,8 @@ import "../prism-themes/prism-gruvbox-dark.css";
 import { SERVER_BASE_URL, SUPPORTED_LANGUAGES } from "../../utils/constants";
 
 const Editor = () => {
+  const { id } = useParams();
   const navigate = useNavigate();
-  const params = useParams();
   const [text, setText] = useState("");
   const [language, setLanguage] = useState("js");
   const textareaRef = useRef(null);
@@ -51,31 +51,32 @@ const Editor = () => {
   }, [text, language]);
 
   useEffect(() => {
-    if (params.id) fetchData();
-    else {
+    const fetchData = async () => {
+      const response = await fetch(`${SERVER_BASE_URL}/bin/${id}`);
+      const data = await response.json();
+      if (response.ok) {
+        setLanguage(data.language);
+        setText(data.content);
+      }
+    };
+
+    if (id) {
+      fetchData();
+    } else {
       textareaRef.current.value = "";
       setText("");
     }
-  }, [params.id]);
-
-  const fetchData = async () => {
-    const response = await fetch(`${SERVER_BASE_URL}/bin/${params.id}`);
-    const data = await response.json();
-    if (response.ok) {
-      setLanguage(data.language);
-      setText(data.content);
-    }
-  };
+  }, [id]);
 
-  const lines = text.split("\n");
+  const lines = useMemo(() => text.split("\n"), [text]);
 
   return (
     <div className={styles.container}>
-      {!params.id && (
+      {!id && (
         <>
           <select
             className={styles.languages}
-            onChange={(event) => handleLanguageChange(event)}
+            onChange={handleLanguageChange}
           >
             {Object.keys(SUPPORTED_LANGUAGES).map((language) => (
               <option
@@ -87,7 +88,7 @@ const Editor = () => {
               </option>
             ))}
           </select>
-          <button className={styles.btn__save} onClick={() => handleClick()}>
+          <button className={styles.btn__save} onClick={handleClick}>
             <img src="assets/icons/save.svg" className={styles.btn__icon} />
           </button>
         </>
@@ -110,7 +111,7 @@ const Editor = () => {
             className={styles.codespace__textarea}
             onChange={handleTextChange}
             onScroll={handleScroll}
-            hidden={params.id ? true : false}
+            style={{ display: id ? 'none' : 'block' }}
             spellCheck="false"
             ref={textareaRef}
             placeholder="Type your text here..."
diff --git a/client/src/components/Editor/Editor.module.css b/client/src/components/Editor/Editor.module.css
index 5eabc10..579f3bc 100644
--- a/client/src/components/Editor/Editor.module.css
+++ b/client/src/components/Editor/Editor.module.css
@@ -38,7 +38,7 @@
 .line__numbers {
   display: flex;
   flex-direction: column;
-  padding: 0px 20px 0px 0px;
+  padding-right: 20px;
   overflow-y: auto;
 }
 
@@ -47,7 +47,7 @@
 }
 
 .line__number {
-  margin: 0px;
+  margin: 0;
   font-size: 16px;
   line-height: 1.5rem;
   text-align: right;
@@ -74,7 +74,7 @@
   resize: none;
   border: none;
   outline: none;
-  padding: 0px;
+  padding: 0;
   overflow-y: auto;
 }
 
diff --git a/client/src/components/Header/Header.jsx b/client/src/components/Header/Header.jsx
index 9217299..a69803a 100644
--- a/client/src/components/Header/Header.jsx
+++ b/client/src/components/Header/Header.jsx
@@ -1,5 +1,4 @@
 import React from 'react'
-
 import styles from './Header.module.css'
 
 const Header = () => {
-- 
cgit v1.2.3-73-gaa49b