From db2c2ca2db44e4971ec41d3245119f7bc9d25d37 Mon Sep 17 00:00:00 2001 From: Josef Bacik Date: Fri, 24 Jan 2020 09:32:39 -0500 Subject: btrfs: hold a ref on the root in prepare_to_merge We look up the reloc roots corresponding root, we need to hold a ref on that root. Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba --- fs/btrfs/relocation.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 83fd74cade3b..b85850823a1b 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -2521,6 +2521,7 @@ again: root = read_fs_root(fs_info, reloc_root->root_key.offset); BUG_ON(IS_ERR(root)); + BUG_ON(!btrfs_grab_fs_root(root)); BUG_ON(root->reloc_root != reloc_root); /* @@ -2532,6 +2533,7 @@ again: btrfs_update_reloc_root(trans, root); list_add(&reloc_root->root_list, &reloc_roots); + btrfs_put_fs_root(root); } list_splice(&reloc_roots, &rc->reloc_roots); -- cgit