Age | Commit message (Collapse) | Author | Files | Lines |
|
Give the user an opportunity to fix the error or save the configuration
under a different path.
Reported-by: Hiromu Yakura <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
The ARRAY_SIZE macro in scripts/genksyms/genksyms.c returns a value of
type size_t. That value is being compared to a variable of type int in
a loop in read_node(). Change the int variable to size_t type as well,
so we don't do signed vs unsigned type comparisons with all the
potential promotion/sign extension trouble that can cause (also
silences compiler warnings at high levels of warnings).
Signed-off-by: Jesper Juhl <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
The commit f02e8a6 sorts symbols placing each of them in its own elf section.
The sorting and merging into the canonical sections are done by the linker.
Unfortunately modpost to generate Module.symvers file parses vmlinux
(already linked) and all modules object files (which aren't linked yet).
These aren't sanitized by the linker yet. That breaks modpost that can't
detect license properly for modules. This patch makes modpost aware of
the new exported symbols structure.
Thanks to Arnaud Lacombe <[email protected]> and Anders Kaseorg
<[email protected]> for providing useful suggestions about code.
This work was supported by a hardware donation from the CE Linux Forum.
Reported-by: Jan Beulich <[email protected]>
Signed-off-by: Alessio Igor Bogani <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
|
|
This patch silences the "make -C /usr/src/git O=/usr/src/git/build/."
message shown when using the generated makefile in KBUILD_OUTDIR.
Signed-off-by: Peter Foley <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
The specialized printer for headers (espectially autoconf.h) is missing
fixup code for S_HEX symbol's "0x" prefix. As long as kconfig does not
warn for such missing prefix, this code is needed. Fix this.
In the same time, fix some nits in `header_print_symbol()'.
Cc: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Broken-by: Arnaud Lacombe <[email protected]>
Reported-by: Randy Dunlap <[email protected]>
Reported-by: Mauro Carvalho Chehab <[email protected]>
Acked-by: Mauro Carvalho Chehab <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6
* 'rc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6:
kbuild: Do not write to builddir in modules_install
|
|
After the test
if (!submenu || ...)
continue;
the variable `submenu' can _not_ be NULL, so do not test for this
situation.
Cc: Nir Tzachar <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
nconf does not check the validity of the current menu when help is
requested (with either <F2>, '?' or 'h'). This leads to a NULL pointer
dereference when an empty menu is encountered.
The following reduced testcase exposes the problem:
config DEP
bool
menu "FOO"
config BAR
bool "BAR"
depends on DEP
endmenu
Issue will happen when entering menu "FOO" and requesting help.
nconf is the only front-end which do not filter the validity of the
current menu. Such filter can not really happen beforehand as other key
which does not deals with the current menu might be entered by the user,
so just bails out earlier if we encounter an invalid menu.
Cc: Nir Tzachar <[email protected]>
Cc: Andrej Gelenberg <[email protected]>
Reported-by: Andrej Gelenberg <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
nconf is the only front-end which does not use this helper, but prefer
to copy/paste the code. The test wrt. menu validity added in this
version of the code is bogus anyway as an invalid menu will get
dereferenced a few line below by calling menu_get_prompt().
For now, convert nconf to use menu_get_ext_help(), as do every other
front-end. We will deals with menu validity checks properly in a
separate commit.
Cc: Nir Tzachar <[email protected]>
Cc: Andrej Gelenberg <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
I am seeing Wunused-but-set warning while make nconfig. Looks like
active_menu is not used. Removing it fixes the warning.
Signed-off-by: Raghavendra D Prabhu <[email protected]>
Acked-by: WANG Cong <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
Let depmod.sh create a temporary directory in /tmp instead of writing to
the build directory as root. The mktemp utility should be available on
any recent system (and there is already scripts/gen_initramfs_list.sh
relying on it).
Reported-by: Christian Kujau <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
Sync with Linus' tree to be able to apply pending patches that
are based on newer code already present upstream.
|
|
kbuild/kconfig
|
|
This function has not much reason to be public. In the mean time, convert
declaration from K&R C to ISO C.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Commit 5a6f8d2bd9e3392569ed6f29ea4d7210652f929b removed `kconfig_load()',
however, it missed an hidden prototypes in `lkc.h'. Fix this.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
This variable is not used outside of main() so there is not much reason keeping
it global. Ensure it is initialized as gcc has no way to know that normal
execution path expect only one option switch to be given on the command line
(except when we request help). As a result, we always initialize
`defconfig_file' before using it.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Make conf_write_symbol() grammar agnostic to be able to use it from different
code path. These path pass a printer callback which will print a symbol's name
and its value in different format.
conf_write_symbol()'s job become mostly only to prepare a string for the
printer. This avoid to have to pass specialized flag to generic
functions
Signed-off-by: Arnaud Lacombe <[email protected]>
[mmarek: rebased on top of de12518 (kconfig: autogenerated config_is_xxx
macro)]
Signed-off-by: Michal Marek <[email protected]>
|
|
Considering the following configuration:
config F
bool "F"
choice AB
bool "AB"
config A
bool "A"
config B
bool "B"
endchoice
if A
config D
bool
default y if F
select E
config E
bool "E"
endif
if B
config D
bool
default y if F
select E
config E
bool "E"
endif
The following configuration:
CONFIG_F=y
CONFIG_A=y
# CONFIG_B is not set
CONFIG_D=y
CONFIG_E=y
emits a spurious warning:
(D) selects E which has unmet direct dependencies (B)
If a symbol appears in two different branch of the tree, it should inherit the
dependency of both parent, not just the last one.
Reported-by: Yann E. Morin <[email protected]>
Tested-by: Yann E. Morin <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
checkpatch.pl warns about using __attribute__((packed)) in kernel
headers: "__packed is preferred over __attribute__((packed))". If one
follows that advice it could cause problems in the exported header
files, because the outside world doesn't know about this shortcut.
For example busybox will fail to compile:
CC miscutils/ubi_attach_detach.o
In file included from miscutils/ubi_attach_detach.c:27:0:
/usr/include/mtd/ubi-user.h:330:3: error: conflicting types for ‘__packed’
/usr/include/mtd/ubi-user.h:314:3: note: previous declaration of ‘__packed’ was here
...
Fix the problem by substituting __packed with __attribute__((packed)) in
the header_install.pl script.
Cc: Artem Bityutskiy <[email protected]>
CC: Joe Perches <[email protected]>
Signed-off-by: Markus Trippelsdorf <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
Specify --git-dir when building perf targets to allow out-of-tree
builds using O=<build-dir>.
The shell command in `git archive' had to be modified to allow proper
file name expansion of the files listed in MANIFEST.
Signed-off-by: matt mooney <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
git://github.com/lacombar/linux-2.6 into kbuild/kbuild
|
|
The placement of the opening brace "{" after 'if' statements in
scripts/docproc.c is inconsistent. Most are placed on the same line as the 'if'
statement itself as per CodingStyle, but a few are not. This patch cleans up
the inconsistency. We save a few source lines and the file then uses the same
style throughout, which is nice.
Signed-off-by: Jesper Juhl <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
|
|
Signed-off-by: Jonathan Neuschäfer <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
|
|
Warn about uses of printk_ratelimit() because it uses a global state and
can hide subsequent useful messages.
Signed-off-by: Joe Perches <[email protected]>
Cc: Andy Whitcroft <[email protected]>
Cc: Richard Weinberger <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
|
|
This patch removes the assumption of the bootgraph.pl script that the
timing information reported by PRINTK_TIME will contain at least one
entry with a time of less than 100 seconds.
Not all boards correctly reset the system timer and in many cases the
inital times reported by PRINTK_TIME is high. When this occurs the
bootchart.pl script fails to give any useful output.
This patch sets the $firsttime variable to the largest value expected
by PRINTK_TIME
Signed-off-by: Andrew Murray <[email protected]>
Acked-by: Arjan van de Ven <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
|
|
depmod from module-init-tools < 3.13 and the busybox depmod check if the
kernel release starts with <num>.<num>.<num>. To support these versions,
we create a symlink with two numbers prepended.
Signed-off-by: Michal Marek <[email protected]>
|
|
Do not bloat the Makefile with multiline shell statements. No
user-visible change intended.
Signed-off-by: Michal Marek <[email protected]>
|
|
Cc: David Gibson <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Cc: David Gibson <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
This avoids the creation of a top-level `lex.backup' when the lexer gets
re-generated.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
input file
Renaming hash and lookup functions on the command line would reduces its
genericity. Use the .gperf file to pass this information. Do the same for the
target language.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
This is needed to have make(1) correctly link the implicit rules which
generate the _shipped file from the lexer/parser to the final file.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
Cc: David Gibson <[email protected]>
Cc: Michal Marek <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
On the same model as `basetarget', it represents the filename of first
prerequisite with directory and extension stripped.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
This patch silences a Makefile.asm-generic message
by defining a dummy rule for all.
make -f /usr/src/git/scripts/Makefile.asm-generic \
obj=arch/x86/include/generated/asm
make[1]: Nothing to be done for `all'.
Signed-off-by: Peter Foley <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
|
|
kbuild/kconfig
|
|
|
|
|
|
As the `gconf' frontend is un-maintained, go the easy way by silencing
the "warning: no previous prototype for '<fn>'" warnings.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
The only call site of renderer_toggled() has been commented out since Apr. 2003,
as per Linus' Linux history repository:
commit e7f67eb3c0570aa50c1cc0707b478a6d93bdc255
Author: Roman Zippel <[email protected]>
Date: Fri Apr 4 04:18:05 2003 -0800
[PATCH] gconf update
A gconf update by Romain Li<C3><A9>vin <[email protected]>
- fixed bug when double-clicking for changing value.
- expand row when enabling a row with a submenu.
- various bug fixes
As this result in a warning:
scripts/kconfig/gconf.c:891:13: warning: 'renderer_toggled' defined but not used
just nuke that code.
Signed-off-by: Arnaud Lacombe <[email protected]>
|
|
This interface is not (and has never been ?) used by any frontend, just get rid
of it.
Signed-off-by: Arnaud Lacombe <[email protected]>
|