| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2013-07-12 | lglock: Update lockdep annotations to report recursive local locks | Michel Lespinasse | 1 | -6/+6 | |
| Oleg Nesterov recently noticed that the lockdep annotations in lglock.c are not sufficient to detect some obvious deadlocks, such as lg_local_lock(LOCK) + lg_local_lock(LOCK) or spin_lock(X) + lg_local_lock(Y) vs lg_local_lock(Y) + spin_lock(X). Both issues are easily fixed by indicating to lockdep that lglock's local locks are not recursive. We shouldn't use the rwlock acquire/release functions here, as lglock doesn't share the same semantics. Instead we can base our lockdep annotations on the lock_acquire_shared (for local lglock) and lock_acquire_exclusive (for global lglock) helpers. I am not proposing new lglock specific helpers as I don't see the point of the existing second level of helpers :) Noticed-by: Oleg Nesterov <[email protected]> Signed-off-by: Michel Lespinasse <[email protected]> Cc: Lai Jiangshan <[email protected]> Cc: "Srivatsa S. Bhat" <[email protected]> Cc: Rusty Russell <[email protected]> Cc: Andi Kleen <[email protected]> Cc: "Paul E. McKenney" <[email protected]> Cc: Steven Rostedt <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Peter Zijlstra <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]> | |||||
| 2012-05-29 | brlocks/lglocks: turn into functions | Andi Kleen | 1 | -0/+89 | |
| lglocks and brlocks are currently generated with some complicated macros in lglock.h. But there's no reason to not just use common utility functions and put all the data into a common data structure. Since there are at least two users it makes sense to share this code in a library. This is also easier maintainable than a macro forest. This will also make it later possible to dynamically allocate lglocks and also use them in modules (this would both still need some additional, but now straightforward, code) [[email protected]: checkpatch fixes] Signed-off-by: Andi Kleen <[email protected]> Cc: Al Viro <[email protected]> Cc: Rusty Russell <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Rusty Russell <[email protected]> Signed-off-by: Al Viro <[email protected]> | |||||