aboutsummaryrefslogtreecommitdiff
path: root/drivers
AgeCommit message (Collapse)AuthorFilesLines
2016-03-30staging/lustre/llite: merge lclient.h into llite/vvp_internal.hJohn L. Hammond12-417/+408
Move the definition of struct cl_client_cache to lustre/include/cl_object.h and move the rest of lustre/include/lclient.h in to lustre/llite/vvp_internal.h. Signed-off-by: John L. Hammond <[email protected]> Reviewed-on: http://review.whamcloud.com/12592 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5971 Reviewed-by: Jinshan Xiong <[email protected]> Reviewed-by: James Simmons <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/llite: make sure we do cl_page_clip on the last pageLi Dongyang1-5/+7
When we are doing a partial IO on both first and last page, the logic currently only call cl_page_clip on the first page, which will end up with a incorrect i_size. Signed-off-by: Li Dongyang <[email protected]> Reviewed-on: http://review.whamcloud.com/11630 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5552 Reviewed-by: Ian Costello <[email protected]> Reviewed-by: Niu Yawei <[email protected]> Reviewed-by: Li Xi <[email protected]> Reviewed-by: Jinshan Xiong <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/llite: deadlock for page writeJinshan Xiong1-2/+2
Writing thread already locked page #1, and then wait for the Writeback bit of page #2; Ptlrpc thread is composing a write RPC, so it sets Writeback on page #2 and tries to lock page #1 to make it ready. Deadlocked. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/9036 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4540 Reviewed-by: wangdi <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/llite: clip page correctly for vvp_io_commit_syncJinshan Xiong1-5/+7
The original code was wrong which clipped page incorrectly for partial pages started with zero. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/8531 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4201 Reviewed-by: Andreas Dilger <[email protected]> Reviewed-by: wangdi <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre: update comments after cl_lock simplificationBobi Jam2-124/+19
Update comments to reflect current cl_lock situations. Signed-off-by: Bobi Jam <[email protected]> Reviewed-on: http://review.whamcloud.com/13137 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6046 Reviewed-by: John L. Hammond <[email protected]> Reviewed-by: Jinshan Xiong <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: cl_lock simplificationJinshan Xiong33-5525/+1168
In this patch, the cl_lock cache is eliminated. cl_lock is turned into a cacheless data container for the requirements of locks to complete the IO. cl_lock is created before I/O starts and destroyed when the I/O is complete. cl_lock depends on LDLM lock to fulfill lock semantics. LDLM lock is attached to cl_lock at OSC layer. LDLM lock is still cacheable. Two major methods are supported for cl_lock: clo_enqueue and clo_cancel. A cl_lock is enqueued by cl_lock_request(), which will call clo_enqueue() methods for each layer to enqueue the lock. At the LOV layer, if a cl_lock consists of multiple sub cl_locks, each sub locks will be enqueued correspondingly. At OSC layer, the lock enqueue request will tend to reuse cached LDLM lock; otherwise a new LDLM lock will have to be requested from OST side. cl_lock_cancel() must be called to release a cl_lock after use. clo_cancel() method will be called for each layer to release the resource held by this lock. At OSC layer, the reference count of LDLM lock, which is held at clo_enqueue time, is released. LDLM lock can only be canceled if there is no cl_lock using it. Signed-off-by: Bobi Jam <[email protected]> Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/10858 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3259 Reviewed-by: John L. Hammond <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: generalize cl_sync_ioJinshan Xiong3-45/+44
To make cl_sync_io interfaces not just wait for pages, but to be a generic synchronization mechanism. Also remove cl_io_cancel that became not used. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/8656 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4198 Reviewed-by: Bobi Jam <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre: Remove struct ll_iattrOleg Drokin6-66/+6
This was a compat code from the time it had ia_attr_flags. Instead convert all the cryptic callers that did ((struct ll_iattr *)&op_data->op_attr)->ia_attr_flags into direct access to op_data->op_attr_flags This also makes lustre/include/linux/obd.h not needed anymore, so remove it. Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/llite: remove some cl wrappersJohn L. Hammond7-68/+35
In llite remove the wrapper functions and macros: cl_i2info() cl_i2sbi() cl_iattr2fd() cl_inode_info cl_inode_mode() cl_inode_{a,m,c}time() cl_isize_{read,write,write_nolock}() Signed-off-by: John L. Hammond <[email protected]> Reviewed-on: http://review.whamcloud.com/12850 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: James Simmons <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/obd: remove struct client_obd_lockJohn L. Hammond11-175/+105
Remove the definition of struct client_obd_lock and the functions client_obd_list_{init,lock,unlock,done}(). Use spinlock_t for the cl_{loi,lru}_list_lock members of struct client_obd and call spin_{lock,unlock}() directly. Signed-off-by: John L. Hammond <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/lmv: remove lmv_init_{lock,unlock}()John L. Hammond3-16/+13
In struct lmv_obd rename the init_mutex member to lmv_init_mutex. Remove the compat macros lmv_init_{lock,unlock}() and use mutex_{lock,unlock}(&lmv->lmv_init_mutex) instead. Signed-off-by: John L. Hammond <[email protected]> Reviewed-on: http://review.whamcloud.com/12115 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Bob Glossman <[email protected]> Reviewed-by: James Simmons <[email protected]> Reviewed-by: Dmitry Eremin <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/llite: remove lli_lvbJohn L. Hammond6-44/+48
In struct ll_inode_info remove the struct ost_lvb lli_lvb member and replace it with obd_time lli_{a,m,c}time. Rename ll_merge_lvb() to ll_merge_attr(). Remove cl_merge_lvb() and replace calls to it with calls to ll_merge_attr(). Signed-off-by: John L. Hammond <[email protected]> Reviewed-on: http://review.whamcloud.com/12849 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Bobi Jam <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: optimize read ahead codeJinshan Xiong18-123/+208
It used to check each page in the readahead window is covered by a lock underneath, now cpo_page_is_under_lock() provides @max_index to help decide the maximum ra window. @max_index can be modified by OSC to extend the maximum lock region, to align stripe boundary at LOV, and to make sure the readahead region at least covers read region at LLITE layer. After this is done, usually readahead code calls cpo_page_is_under_lock() for each stripe. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/8523 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: remove stackable cl_page completelyJinshan Xiong22-528/+257
>From now on, cl_page becomes one to one mapping of vmpage. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7895 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Bobi Jam <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/osc: add weight function for DLM lockJinshan Xiong6-139/+89
Use weigh_ast to decide if a lock covers any pages. In recovery, weigh_ast will be used to decide if a DLM read lock covers any locked pages, or it will be canceled instead being recovered. The problem with the original implementation is that it attached each osc_page to an osc_lock also changed lock state to add every pages for readahead. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7894 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Bobi Jam <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: add pages into writeback cache in batchesJinshan Xiong20-896/+792
in ll_write_end(), instead of adding the page into writeback cache directly, it will be held in a page list. After enough pages have been collected, issue them all with cio_commit_async(). Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7893 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Bobi Jam <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/obdclass: Add a preallocated percpu cl_envJinshan Xiong5-23/+152
This change adds support for a single preallocated cl_env per CPU which can be used in circumstances where reschedule is not possible. Currently this interface is only used by the ll_releasepage function. Signed-off-by: Jinshan Xiong <[email protected]> Signed-off-by: Prakash Surya <[email protected]> Reviewed-on: http://review.whamcloud.com/8174 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Lai Siyao <[email protected]> Reviewed-by: Bobi Jam <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/clio: collapse layer of cl_pageJinshan Xiong19-604/+394
Move radix tree to osc layer to for performance improvement. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7892 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Lai Siyao <[email protected]> Reviewed-by: Bobi Jam <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/osc: to drop LRU pages with cl_lru_workJinshan Xiong8-25/+85
This way we can drop it async. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7891 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Lai Siyao <[email protected]> Reviewed-by: Bobi Jam <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/osc: Adjustment on osc LRU for performanceJinshan Xiong8-157/+235
Add and discard pages from LRU in batch. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7890 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Niu Yawei <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre: Reintroduce global env listJinshan Xiong5-6/+92
This reverts a patch that was merged before lustre client was introduced into the stagign tree, so it's not in the history. The performance dropped a lot when memory reclaim process kicked in as ll_releasepage() was called to destroy lustre pages. It turned out that big overhead to allocate cl_env and keys on the fly so we have to revert this patch. The original problem for the reverted patch would be solved in a follow on patch instead. Signed-off-by: Jinshan Xiong <[email protected]> Reviewed-on: http://review.whamcloud.com/7888 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3321 Reviewed-by: Niu Yawei <[email protected]> Reviewed-by: Lai Siyao <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre: merge lclient/*.c into llite/John L. Hammond4-40/+49
Separate lclient was necessary to be shared between different client implementations, make no sense to have them separate in Linux kernel. Signed-off-by: John L. Hammond <[email protected]> Based-on: http://review.whamcloud.com/10171 Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre: Get rid of CFS_PAGE_MASKOleg Drokin13-33/+32
CFS_PAGE_MASK is the same as PAGE_MASK, so get rid of it. We are replacing it with PAGE_MASK instead of PAGE_CACHE_MASK because PAGE_CACHE_* stuff is apparently going away. Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging/lustre/obdclass: limit lu_site hash table sizeOleg Drokin1-1/+1
Allocating a big hash table using the formula for osd does not really work for clients. We will create new hash table for each mount on a single client which is a lot of memory more than expected. This patch limits the hash table up to 8M which has 524288 entries Signed-off-by: Li Dongyang <[email protected]> Reviewed-on: http://review.whamcloud.com/18048 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7689 Reviewed-by: Fan Yong <[email protected]> Reviewed-by: Alex Zhuravlev <[email protected]> Signed-off-by: Oleg Drokin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: xgifb: fix block commentsClifton Barnes3-63/+88
fix checkpatch.pl warning about 'Block comments use a trailing */ on a separate line' and 'Block comments use * on subsequent lines' Signed-off-by: Clifton Barnes <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: dgnc: fix Logical continuations.Daeseok Youn1-3/+3
fix checkpatch.pl warning about 'Logical continuations should be on the previous line' Signed-off-by: Daeseok Youn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: dgnc: fix 'line over 80 characters'Daeseok Youn1-3/+9
fix checkpatch.pl warning about 'line over 80 characters'. I just moved all line comment to above if statement. Signed-off-by: Daeseok Youn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: dgnc: remove parenthesis around the CONST |Daeseok Youn1-13/+13
remove parenthesis around the CONST | CONST. It will be also fixed checkpatch.pl warning about "Alignment should match open parenthesis" becasue parenthesis were removed by this patch. Signed-off-by: Daeseok Youn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: dgnc: replace dgnc_offset_table with bit shift.Daeseok Youn1-32/+12
the dgnc_offset_table has a same value with (1 << port). So I tried to replace dgnc_offset_table array with 1 << port. And also there are redundant assignments(tmp and current_port) inside while loop for checking uart port, and remove them. Signed-off-by: Daeseok Youn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci224: Prefer using the BIT macroH Hartley Sweeten1-33/+38
Fix the checkpatch.pl issues by using the BIT macro and defining some macros for the multi-bit fields. Signed-off-by: H Hartley Sweeten <[email protected]> Cc: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci263: define the register mapH Hartley Sweeten1-3/+8
For completeness, define the registers used by this driver and remove the magic numbers. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci263: tidy up digital output subdevice initH Hartley Sweeten1-7/+8
For aesthetics, add some whitespace to the digital output subdevice initialization. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci263: fix block commentsH Hartley Sweeten1-30/+30
Fix the checkpatch.pl issues: WARNING: Block comments use * on subsequent lines Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: drivers: fix possible bug in comedi_handle_events()H Hartley Sweeten1-1/+4
This function assumes that the async subdevice has a cancel() function. It looks like all the current comedi drivers implement a cancel() for the async subdevices except for the dt2814 analog input usbdevice. Fix comedi_handle_events() so it does not try to call a non-existent cancel() function. Add a dev_warn() to __comedi_device_postconfig_async() so that any new driver authors will be reminded to implement the cancel(). Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: drivers: tidy up insn_rw_emulate_bits()H Hartley Sweeten1-19/+16
Tidy up this function and fix the checkpatch.pl issues: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: c6xdigio: Prefer using the BIT macroH Hartley Sweeten1-2/+2
Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci230: Prefer kernel type 'u64' over 'uint64_t'H Hartley Sweeten1-5/+5
Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pci230: Prefer using the BIT macroH Hartley Sweeten1-67/+74
Fix the checkpatch.pl issues by using the BIT macro and defining some macros for the multi-bit fields. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_dio200_common: document spinlock definitionH Hartley Sweeten1-1/+1
Fix the checkpatch.pl issue: CHECK: spinlock_t definition without comment Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_dio200_common: Prefer 'unsigned int' to bare use of ↵H Hartley Sweeten1-5/+5
'unsigned' Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pc263: fix block commentsH Hartley Sweeten1-31/+31
Fix the checkpatch.pl issues: WARNING: Block comments use * on subsequent lines Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pc263: define the register mapH Hartley Sweeten1-7/+6
For completeness, define the registers used by this driver and remove the magic numbers. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pc263: tidy up comedi_driver definitionH Hartley Sweeten1-7/+7
For aesthetics, add some whitespace to the comedi_driver definition. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: comedi: amplc_pc263: tidy up digital output subdevice initH Hartley Sweeten1-7/+8
For aesthetics, add some whitespace to the digital output subdevice initialization. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30Staging: android: change memory allocation style in ion.cBen Marsh1-5/+5
Chnages memory allocation style in order to silence a checkpatch.pl warning. Signed-off-by: Ben Marsh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30android: remove timed output/gpio driverRob Herring6-362/+0
timed_output was only used by the Android vibrator HAL which has now learned how to use LED triggers instead[1]. Any users of it in AOSP are on ancient kernels. Adding support for LED triggers is purely DT changes and proper kernel config. [1] https://android.googlesource.com/platform%2Fhardware%2Flibhardware/+/61701df363310a5cbd95e3e1638baa9526e42c9b Cc: John Stultz <[email protected]> Cc: "Arve Hjønnevåg" <[email protected]> Cc: Riley Andrews <[email protected]> Signed-off-by: Rob Herring <[email protected]> Acked-by: John Stultz <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: unisys: remove wmb() in visordriver_remove_deviceDavid Kershner1-10/+2
Don't need to have a wmb() in visordriver_remove_device. Also removed an unnecessary check for drv being null. Signed-off-by: David Kershner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: unisys: removed unused channel_bytes attributeAlexander Curtin1-1/+0
The channel_bytes attribute in the visor_device struct was meant to keep track of the number of bytes in the associated channel of the device. Not only is the variable never set nor used, but the information can already be accessed by referencing visor_device->visorchannel->nbytes. Signed-off-by: Alexander Curtin <[email protected]> Signed-off-by: David Kershner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: unisys: removed 'visor_device.devnodes' fieldAlexander Curtin1-6/+0
The 'visor_device.devnodes' field was used for displaying driver version information through the devmajorminor sysfs attribute, which has recently been removed, rendering the field unnecessary. Signed-off-by: Alexander Curtin <[email protected]> Signed-off-by: David Kershner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-30staging: unisys: removed unused visor_device.type fieldAlexander Curtin1-1/+0
The visor_device.type field was included when preparing to remove the device_info struct. However, it's not used at all, and was already redundant by the existence of the 'visor_device.channel_type_guid' field. Signed-off-by: Alexander Curtin <[email protected]> Signed-off-by: David Kershner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>