aboutsummaryrefslogtreecommitdiff
path: root/drivers
AgeCommit message (Collapse)AuthorFilesLines
2016-03-28staging: rtl8188eu: rtw_mlme_ext: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-13/+13
Some functions like kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8188eu: rtw_cmd: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-22/+22
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: mlme_linux: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-1/+1
Some functions like kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: vt6656: Fixed multiple logical comparisions warningsParth Sane1-4/+4
Using comparison to false and true is error prone. Fixed multiple warnings as per checkpatch guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: wilc1000: Remove camel case in variable names.Anchal Jain1-3/+3
Remove a problem detect by checkpatch.pl CHECK: Avoid CamelCase: <srcAdd> Signed-off-by: Anchal Jain <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: dgnc: fix camelcase of SerialDriver and PrintDriverDaeseok Youn2-61/+61
fix the checkpatch.pl warning about CamelCase. Signed-off-by: Daeseok Youn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16240: Improve readabilitySvetlana Orlik1-0/+50
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16220: Improve readabilitySvetlana Orlik1-0/+48
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16209: Improve readabilitySvetlana Orlik1-0/+39
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16201: Fix 'line over 80 characters' warningSvetlana Orlik1-39/+117
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16203: Fix 'line over 80 characters' warningSvetlana Orlik1-33/+99
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16204: Fix 'line over 80 characters' warningSvetlana Orlik1-41/+118
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: accel: adis16240: Replace 'unsigned' with 'unsigned int'Svetlana Orlik1-2/+2
Replace 'unsigned' with 'unsigned int' to avoid checkpatch warning. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: iio: ad9832: Replace 'unsigned' with 'unsigned int'Svetlana Orlik1-1/+1
Replace 'unsigned' with 'unsigned int' to avoid checkpatch.pl warning. Signed-off-by: Svetlana Orlik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: comedi: amplc_pci230: Convert macro GAT_CONFIG to static inline ↵Bhaktipriya Shridhar1-16/+22
function Convert macro GAT_CONFIG to static inline function as static inline functions are preferred over macros. This change is possible since the arguments at all call sites have the same type. This was done using Coccinelle: @r@ expression e; @@ - #define GAT_CONFIG(chan, src) e + static inline unsigned int pci230_gat_config(unsigned int chan, + unsigned int src) +{ + return ((chan & 3) << 3) | (src & 7); +} @r1@ expression dev,reg,chan,src; @@ -GAT_CONFIG(chan, src) +pci230_gat_config(chan, src) Also, the comment describing the macro has been removed manually. Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: wilc1000: use mutex instead of struct semaphore hif_sema_deinitChaehyun Lim1-9/+9
This patch replaces struct semaphore hif_sema_deinit with struct mutex hif_deinit_lock. It is better to use mutex because mutex gives better performance than semaphore. Signed-off-by: Chaehyun Lim <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: vt6655: fix style violations for lines over 80 charactersKathryn Hampton7-51/+106
This patch addresses line length errors reported by checkpatch.pl that could be fixed with simple line breaks. Signed-off-by: Kathryn Hampton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: speakup: Clear hi font bit from attributesSamuel Thibault1-2/+4
Previously, speakup would see the hi-font bit in attributes. Since this bit has nothing to do with attributes, we need to clear it. Signed-off-by: Samuel Thibault <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: vt6655: defined byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[] as ↵Claudiu Beznea1-2/+2
const arrays. This patch changes byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[] arrays in const arrays since these are not changed anywhere in the code. Signed-off-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: comedi: comedi_fops: Replace 'unsigned' with 'unsigned int'Leslie Klein1-24/+24
Fix checkpatch warning: Prefer 'unsigned int' to bare use of 'unsigned' in file comedi_fops.c Signed-off-by: Leslie Klein <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: comedi: comedi_buf: Replace 'unsigned' with 'unsigned int'Leslie Klein1-5/+5
Fix checkpatch warning: Prefer 'unsigned int' to bare use of 'unsigned' in file comedi_buf.c Signed-off-by: Leslie Klein <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: comedi: dt282x: tidy up register bit definesH Hartley Sweeten1-32/+33
Arnd Bergmann pointed out that gcc-6 warns about passing negative signed integer into swab16() due to the macro expansion of 'outw'. It appears that the register map constants are causing the warnings. Actually, it might just be the (1 << 15) ones... Convert all the constants as suggested by checkpatch.pl: CHECK: Prefer using the BIT macro The BIT() macro will make all the constants explicitly 'unsigned', which helps to avoid the warning. Fix the, unsused, DT2821_CHANCSR_PRESLA() macro. The "Present List Address" (PRESLA) bits in the CHANCSR register are read only. This define was meant to extract the bits from the read value. Signed-off-by: H Hartley Sweeten <[email protected]> Reported-by: Arnd Bergmann <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Tested-by: Arnd Bergmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: wlan-ng: Use x instead of x != NULL.Sandhya Bankar1-2/+2
Use x instead of x != NULL.This issue is detected by checkpatch.pl script. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: wlan-ng: defined oui_rfc1042[] and oui_8021h[] arrays as const arraysClaudiu Beznea1-2/+2
This patch defines oui_rfc1042[] and oui_8021h[] arrays from p80211conv.c as const arrays since these are not changed anywhere in code. Signed-off-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: rtl8188eu: rtw_efuse: Use sizeof type *pointer instead of sizeof type.Sandhya Bankar1-1/+1
Use sizeof type *pointer instead of sizeof type. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: Fixed FSF address warning in ieee80211.cParth Sane1-4/+0
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: Fixed FSF address warning in hal_init.cParth Sane1-4/+0
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: Fixed FSF address warning in ethernet.hParth Sane1-4/+0
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: Fixed FSF address warning in drv_types.hParth Sane1-4/+0
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: Fixed FSF address warning in basic_types.hParth Sane1-4/+0
Fixed checkpatch warning after removing FSF address paragraph as per guidelines. Signed-off-by: Parth Sane <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: rtl871x_ioctl_linux: Clean up tests if NULL returned on ↵Bhaktipriya Shridhar1-2/+2
failure Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: rtl871x_cmd: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-40/+40
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: rtl871x_mlme: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-2/+2
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: usb_ops_linux: Clean up tests if NULL returned on failureBhaktipriya Shridhar1-1/+1
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: os_intfs: Change form of NULL comparisonsBhaktipriya Shridhar1-2/+2
Change null comparisons of the form x == NULL to !x. This was done using Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8712: rtl871x_ioctl_set: Remove unused macroBhaktipriya Shridhar1-6/+0
Removed Unused macro IS_MAC_ADDRESS_BROADCAST. Grep'd to find occurences. Signed-off-by: Bhaktipriya Shridhar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: rtl8723au: Remove unnecessary return statement.Sandhya Bankar1-2/+0
Remove unnecessary return statement. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: rtl8723au: rtl8723a_rf6052: Remove unnecessary semicolon.Sandhya Bankar1-1/+1
Remove unnecessary semicolon. Coccinelle sementic patch as follows: @r_case@ position p; @@ switch (...) { case ...: ...;@p } @r_default@ position p; @@ switch (...) { default: ...;@p } @r1@ statement S; position p1; position p != {r_case.p, r_default.p}; identifier label; @@ ( label:; | S@p1;@p ) Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8723au: Fix line longer than 80 columns.Edward Lipinsky1-1/+2
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Edward Lipinsky <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: rtl8192u: fix typo in debug messageNik Nyby2-2/+2
This fixes a mis-spelled word in a few debug statements. Signed-off-by: Nik Nyby <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: rtl8192u: Remove unnecessary semicolon.Sandhya Bankar1-1/+1
Remove unnecessary semicolon.This issue is found by coccinelle script. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: rtl8192u: remove extra blank lines.Ben Marsh1-22/+0
This patch removes blank lines in r8192U_wx.c that were flagged by checkpatch.pl Signed-off-by: Ben Marsh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: netlogic: Remove & from function name.Sandhya Bankar1-1/+1
Remove & from function name,when function name passed as an argument to another function. Function name is used as pointer without &. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: iio: use kernel preferred block commenting styleAlison Schofield7-17/+23
Use * on subsequent lines and trailing */ on a separate line in block comments. Signed-off-by: Alison Schofield <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type.Sandhya Bankar1-2/+2
Use sizeof type *pointer instead of sizeof type. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: lustre: rpc: Use sizeof type *pointer instead of sizeof type.Sandhya Bankar1-1/+1
Use sizeof type *pointer instead of sizeof type. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: lustre: socklnd: Remove return statement from void function.Sandhya Bankar1-1/+0
Remove return statement from void function. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: lustre: socklnd_lib: Remove return statement from void function.Sandhya Bankar1-3/+0
Remove return statement from void function. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: lustre: lib-move: Remove unnecessary space after cast.Sandhya Bankar1-5/+5
Remove unnecessary space after cast. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28Staging: i4l: pcbit: drv: Remove unnecessary semicolon.Sandhya Bankar1-2/+2
Remove unnecessary semicolon.This issue is detected by coccinelle script. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.