aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/misc
AgeCommit message (Collapse)AuthorFilesLines
2008-04-18drivers: Remove unnecessary inclusions of asm/semaphore.hMatthew Wilcox1-1/+0
None of these files use any of the functionality promised by asm/semaphore.h. It's possible that they rely on it dragging in some unrelated header file, but I can't build all these files, so we'll have fix any build failures as they come up. Signed-off-by: Matthew Wilcox <[email protected]>
2008-04-02USB: fix bug in sg initialization in usbtestAlan Stern1-1/+2
This patch (as1062) fixes a bug in the scatter-gather initialization code in the usbtest driver. When the sg-helper conversion was performed, it wasn't done correctly. Signed-off-by: Alan Stern <[email protected]> CC: Jens Axboe <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-21USB: add new vernier product id to ldusb.cStephen Ware1-0/+2
I have a new ldusb device to go into the device table. Jiri has merged the change for hiddev quirks already. From: Stephen Ware <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-21USB: fix error handling in trancevibratorOliver Neukum1-1/+3
trancevibrator should not pretend success if it returns an error. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: constify function pointer tablesJan Engelhardt1-1/+1
Signed-off-by: Jan Engelhardt <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: misc: legousbtower: semaphore to mutexDaniel Walker1-14/+16
The dev->sem conforms to mutex style usage. This patch converts it to use the struct mutex type, and new API. There is also a small style fix around this comment, /* unlock here as tower_delete frees dev */ Where I broke the line up to meet the 80 char limit. Signed-off-by: Daniel Walker <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: Spelling fixesJoe Perches2-2/+2
Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: testing driver: don't free a locked mutexAndrew Morton1-2/+0
Dopey thing to do and lockdep will (or should) warn. Spotted by Daniel Walker. Cc: Matthias Kaehlcke <[email protected]> Cc: Daniel Walker <[email protected]> Cc: Ingo Molnar <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: testing driver: convert dev->sem to mutexMatthias Kaehlcke1-8/+9
USB testing driver: convert semaphore dev->sem to the mutex API Signed-off-by: Matthias Kaehlcke <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: cypress_cy7c63: updated contact/usage informationOliver Bock1-2/+5
here's a minor update to the cypress_cy7c63 driver providing new contact and usage information. From: Oliver Bock <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: sis FB driver: *_ioctl32_conversion functions do not exist in recent ↵Fernando Luis Vazquez Cao2-30/+0
kernels Remove dead code while at it. Signed-off-by: Fernando Luis Vazquez Cao <[email protected]> Cc: Thomas Winischhofer <[email protected]> Cc: Greg KH <[email protected]> Cc: "Antonino A. Daplas" <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01usb: fix usbtest halt check on big endian systemsJan Andersson1-0/+1
usbtest did not swap the received status information when checking for a non-zero value and failed to discover halted endpoints on big endian systems. Cc: stable <[email protected]> Signed-off-by: Jan Andersson <[email protected]> Acked-by: David Brownell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-11-28USB: FIx locks and urb->status in adutux (updated)Pete Zaitcev1-123/+139
Two main issues fixed here are: - An improper use of in-struct lock to protect an open count - Use of urb status for -EINPROGRESS Also, along the way: - Change usb_unlink_urb to usb_kill_urb. Apparently there's no need to use usb_unlink_urb whatsoever in this driver, and the old use of usb_kill_urb was outright racy (it unlinked and immediately freed). - Fix indentation in adu_write. Looks like it was damaged by a script. - Vitaly wants -EBUSY on multiply opens. - bInterval was taken from a wrong endpoint. Signed-off-by: Pete Zaitcev <[email protected]> Signed-off-by: Vitaliy Ivanov <[email protected]> Tested-by: Vitaliy Ivanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-11-28USB: fix usbled disconnect read race #2Oliver Neukum1-1/+3
usbled has a race where show methods for attributes in sysfs can follow a NULL pointer during disconnect. The correct ordering fixes it. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: open disconnect race in usblcdOliver Neukum1-1/+10
this driver has a possible use after free due to a race when disconnect and open handle intfdata without a lock. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: disconnect open race in legousbtowerOliver Neukum1-1/+13
again, possible use after free due to touching intfdata without lock. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: open disconnect race in iowarriorOliver Neukum1-1/+8
the driver sets intfdata to NULL without lock. Data structures can be freed and accessed. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: missing error check in emi62Oliver Neukum1-0/+4
the emi62 also lacks an error check. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: missing error check in emi26Oliver Neukum1-0/+4
this drivers lacks an error check. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: fix read vs. disconnect race in cytherm driverOliver Neukum1-1/+3
the disconnect method of this driver set intfdata to NULL before removing attribute files. The attributes' read methods will happily follow the NULL pointer. Here's the correct ordering. Signed-off-by : Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: fix locking in idmouseOliver Neukum1-17/+28
Pete caused me to lock at buggy drivers in this respect. The idmouse has a race between open and disconnect. This patch - solves the open/disconnect race - switches locking to mutexes Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB rio500.c: fix check-after-useAdrian Bunk1-12/+3
The Coverity checker spotted that we have already oops'ed if "dev" was NULL in these places. Since "dev" being NULL isn't possible at these places this patch removes the NULL checks. Additionally, I've fixed the formatting of the if's. Signed-off-by: Adrian Bunk <[email protected]> Acked-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB iowarrior.c: fix check-after-useAdrian Bunk1-1/+1
The Coverity checker spotted that we have already oops'ed if "dev" was NULL. Since "dev" being NULL doesn't seem to be possible here this patch removes the NULL check. Signed-off-by: Adrian Bunk <[email protected]> Acked-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-25USB: FTDI Elan driver: Convert ftdi->u132_lock to mutexMatthias Kaehlcke1-65/+65
FTDI Elan driver: Convert the semaphore ftdi->u132_lock to the mutex API Signed-off-by: Matthias Kaehlcke <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-23[PARPORT] Kill useful 'irq' arg from parport_{generic_irq,ieee1284_interrupt}Jeff Garzik1-2/+2
parport_ieee1284_interrupt() was not using its first arg at all. Delete. parport_generic_irq()'s second arg makes its first arg completely redundant. Delete, and use port->irq in the one place where we actually need it. Also, s/__inline__/inline/ to make the code look nicer. Signed-off-by: Jeff Garzik <[email protected]>
2007-10-22[SG] Update drivers to use sg helpersJens Axboe1-2/+2
Signed-off-by: Jens Axboe <[email protected]>
2007-10-19Convert files to UTF-8 and some cleanupsJan Engelhardt3-5/+5
* Convert files to UTF-8. * Also correct some people's names (one example is Eißfeldt, which was found in a source file. Given that the author used an ß at all in a source file indicates that the real name has in fact a 'ß' and not an 'ss', which is commonly used as a substitute for 'ß' when limited to 7bit.) * Correct town names (Goettingen -> Göttingen) * Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313) Signed-off-by: Jan Engelhardt <[email protected]> Signed-off-by: Adrian Bunk <[email protected]>
2007-10-18Add missing newlines to some uses of dev_<level> messagesJoe Perches3-7/+7
Found these while looking at printk uses. Add missing newlines to dev_<level> uses Add missing KERN_<level> prefixes to multiline dev_<level>s Fixed a wierd->weird spelling typo Added a newline to a printk Signed-off-by: Joe Perches <[email protected]> Cc: "Luck, Tony" <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Mark M. Hoffman <[email protected]> Cc: Roland Dreier <[email protected]> Cc: Tilman Schmidt <[email protected]> Cc: David Woodhouse <[email protected]> Cc: Jeff Garzik <[email protected]> Cc: Stephen Hemminger <[email protected]> Cc: Greg KH <[email protected]> Cc: Jeremy Fitzhardinge <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Cc: Alessandro Zummo <[email protected]> Cc: David Brownell <[email protected]> Cc: James Smart <[email protected]> Cc: Andrew Vasquez <[email protected]> Cc: "Antonino A. Daplas" <[email protected]> Cc: Evgeniy Polyakov <[email protected]> Cc: Russell King <[email protected]> Cc: Jaroslav Kysela <[email protected]> Cc: Takashi Iwai <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2007-10-16vt/vgacon: Check if screen resize request comes from userspaceAntonino A. Daplas1-1/+2
Various console drivers are able to resize the screen via the con_resize() hook. This hook is also visible in userspace via the TIOCWINSZ, VT_RESIZE and VT_RESIZEX ioctl's. One particular utility, SVGATextMode, expects that con_resize() of the VGA console will always return success even if the resulting screen is not compatible with the hardware. However, this particular behavior of the VGA console, as reported in Kernel Bugzilla Bug 7513, can cause undefined behavior if the user starts with a console size larger than 80x25. To work around this problem, add an extra parameter to con_resize(). This parameter is ignored by drivers except for vgacon. If this parameter is non-zero, then the resize request came from a VT_RESIZE or VT_RESIZEX ioctl and vgacon will always return success. If this parameter is zero, vgacon will return -EINVAL if the requested size is not compatible with the hardware. The latter is the more correct behavior. With this change, SVGATextMode should still work correctly while in-kernel and stty resize calls can expect correct behavior from vgacon. Signed-off-by: Antonino Daplas <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2007-10-12USB: drivers/usb/misc/sisusbvga/sisusb.c: kill two unused variablesWANG Cong1-2/+0
Kill two unused variables in drivers/usb/misc/sisusbvga/sisusb.c. Signed-off-by: WANG Cong <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: fix gregkh-usb-usb-sisusb2vga-convert-printk-to-dev_-macrosAndrew Morton1-9/+1
drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open': drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used uninitialized in this function I can tell that'll oops just by looking at it. How come this code assume a 7,000 column xterm? :( Cc: Felipe Balbi <[email protected]> Cc: Thomas <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: sisusbvga: Fix bugSatyam Sharma1-3/+1
drivers/usb/misc/sisusbvga/sisusb.c: In function sisusb_open drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: sisusb is used uninitialized in this function is a genuine bug (which will cause oops). We cannot use "sisusb" in error path for (!interface), because sisusb will itself be derived from "interface" later. Signed-off-by: Satyam Sharma <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: fix memory leak in berry_charge driverGreg Kroah-Hartman1-2/+5
This fixes a small memory leak that happens every time the device is plugged in. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: missing test for ESHUTDOWN in adutux driverOliver Neukum1-1/+2
this driver lacks a test for unlink due to ESHUTDOWN Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: ftdi-elan.c: kmalloc + memset conversion to kzallocMariusz Kozlowski1-3/+5
drivers/usb/misc/ftdi-elan.c | 121253 -> 121196 (-57 bytes) drivers/usb/misc/ftdi-elan.o | 209425 -> 209265 (-160 bytes) Signed-off-by: Mariusz Kozlowski <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Convert printk to dev_* macrosFelipe Balbi2-88/+36
This patch convert printk entries to dev_* macros, this provide better debugging and better readability to the code. Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Lindent drivers/usb/misc/sisusbvga/sisusb_struct.hFelipe Balbi1-75/+67
Better indentation Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Lindent drivers/usb/misc/sisusbvga/sisusb_init.hFelipe Balbi1-656/+655
Better indentation Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Lindent drivers/usb/misc/sisusbvga/sisusb_init.cFelipe Balbi1-129/+133
Better indentation Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Lindent drivers/usb/misc/sisusbvga/sisusb.hFelipe Balbi1-60/+58
Better indentation Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Mis-spelled wordFelipe Balbi1-1/+1
Trivial fix Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Remove if 0'ed codeFelipe Balbi4-197/+1
Unused code should be removed. We don't need to increase the size of the file with dead code inside if 0 statements. Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12USB: SisUSB2VGA: Whitespace CleanupsFelipe Balbi5-20/+20
This patches clean some trailing whitespaces in sisusb2vga driver. Signed-off-by: Felipe Balbi <[email protected]> Cc: Thomas Winischhofer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-09-11usb/misc/sisusbvga: add product ID of TARGUS/MCT devicesamson yeung1-0/+1
Device is Targus ACP50US which includes a Magic Control Technologies usb vga device using the SiS315(E) or compatible. Signed-off-by: Samson Yeung <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-07-22Merge branch 'for-linus' of git://git.o-hand.com/linux-rpurdie-backlightLinus Torvalds1-2/+2
* 'for-linus' of git://git.o-hand.com/linux-rpurdie-backlight: leds: cr_bllcd.c: build fix backlight: Convert from struct class_device to struct device backlight: Fix order of Kconfig entries
2007-07-19USB: misc: uss720: clean up urb->status usageGreg Kroah-Hartman1-2/+3
This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-07-19USB: misc: usbtest: clean up urb->status usageGreg Kroah-Hartman1-2/+2
This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-07-19USB: misc: usblcd: clean up urb->status usageGreg Kroah-Hartman1-5/+6
This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-07-19USB: misc: phidgetmotorcontrol: clean up urb->status usageGreg Kroah-Hartman1-6/+7
This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-07-19USB: misc: phidgetkit: clean up urb->status usageGreg Kroah-Hartman1-6/+7
This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Signed-off-by: Greg Kroah-Hartman <[email protected]>