aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/atm
AgeCommit message (Collapse)AuthorFilesLines
2010-08-10USB: speedtouch: fixed more brace and spacing coding style issuesNicolas Kaiser2-11/+11
Fixed spacing coding style issues. Signed-off-by: Nicolas Kaiser <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-08-10USB: speedtouch: fixed brace and spacing coding style issuesNicolas Kaiser2-7/+6
Fixed brace coding style issues. Signed-off-by: Nicolas Kaiser <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-07-09usb/atm/ueagle-atm.c: call atm_dev_signal_change() when signal changes.Karl Hiramoto1-3/+10
Propagate signal changes to upper atm layer. Signed-off-by: Karl Hiramoto <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2010-07-09usb/atm/speedtch.c: call atm_dev_signal_change() when signal changes.Karl Hiramoto1-5/+5
Propagate signal changes to upper atm layer. Signed-off-by: Karl Hiramoto <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2010-07-09usb/atm/cxacru.c: call atm_dev_signal_change() when signal changes.Karl Hiramoto1-9/+9
Propagate signal changes to upper atm layer. Signed-off-by: Karl Hiramoto <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2010-05-25usb: atm: speedtch: use new hex_to_bin() methodAndy Shevchenko1-3/+2
Instead of using own implementation which potentialy has bugs involve hex_to_bin() function. It requires to have hex_to_bin() implementation introduced by starter patch in series. Signed-off-by: Andy Shevchenko <[email protected]> Cc: Duncan Sands <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2010-05-20USB: ueagle: fix Coding StylesJavier Blanco de Torres (Neurowork)1-140/+207
Fixed coding styles in the ueagle usb driver. Signed-off-by: Javier Blanco de Torres <[email protected]> Signed-off-by: Alejandro Sánchez Acosta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-30include cleanup: Update gfp.h and slab.h includes to prepare for breaking ↵Tejun Heo2-1/+1
implicit slab.h inclusion from percpu.h percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <[email protected]> Guess-its-ok-by: Christoph Lameter <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Lee Schermerhorn <[email protected]>
2010-03-02USB: atm: Use FIELD_SIZEOF, trivial cleanup.Thiago Farina1-1/+1
Signed-off-by: Thiago Farina <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: increment driver versionSimon Arlott1-1/+2
Changes: Return an empty string for modulation when there is no connection Fix sysfs unload race conditions Log firmware load process, remove delay Add new configuration interface Remove cxacru-cf.bin Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: remove cxacru-cf.bin loaderSimon Arlott1-28/+3
This has never worked properly because wsize passed to cxacru_cm() is incorrectly set to the number of values instead of the data bytes. The maximum number of values that can be set at once is 7 which means the device will not get enough data to work with and none of the configuration values will be used. At least one existing cxacru-cf.bin file contains invalid data which will prevent the modem from syncing properly. Fixing it is likely to break existing systems, and the new sysfs interface for setting configuration parameters can provide the same functionality. A script is provided to convert from the original format. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: add write-only sysfs attribute for modem configurationSimon Arlott1-1/+75
The modem can be configured using CM_REQUEST_CARD_DATA_SET, although CM_REQUEST_CARD_DATA_GET does not return any data. Tested by setting the modulation (0x0a) option. There is a list of parameters in the following archive, but the meaning of many of them is not well documented: http://sourceforge.net/project/shownotes.php?release_id=301825 This source also indicates that the highest parameter set is 0x4a but this varies by model so an arbitrary limit of 0x7f has been used (the index is a 32-bit integer). Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: firmware writes on OHCI are slow, log progressSimon Arlott1-2/+6
Firmware writing takes 256ms per 4KB with OHCI, which is very slow compared to 7ms per 4KB with UHCI. Until I have access to a hardware USB analyser it may not be possible to determine why this happens. Instead of appearing to do nothing, log progress when writing firmware and then log the ATM device information when finished. Remove an unnecessary 4 second delay. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: document how to interact with the flash memorySimon Arlott1-0/+20
These commands were found by accident... fortunately it still works even if the flash memory is erased, despite having no USB device IDs. Some example sysfs code for raw command access: http://simon.arlott.org/pub/cxacru/raw.c Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: check device isn't being removed during sysfs callsSimon Arlott3-20/+44
It is possible for usb_get_intfdata() to return NULL if sysfs is accessed while the module is being unloaded or the device is being removed. Move the access code to an inline function in usbatm.h, and return -ENODEV if any of the pointers are NULL. It should not be possible for the instance data or atm device to be invalid until after unbind() completes and the sysfs attributes have been removed. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: check data length is not negativeSimon Arlott1-1/+1
When attempting to read data that is not actually an array of values, the length may be negative which causes an Oops due to a likely access off the end of the data array. This bug should not occur under normal use unless the device returns an invalid response. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-03-02USB: cxacru: return an empty value for modulation if there is no connectionSimon Arlott1-2/+2
When there is no connection, return an empty string instead of "0" for the connection modulation. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2009-12-11firmware_class: make request_firmware_nowait more usefulJohannes Berg1-3/+4
Unfortunately, one cannot hold on to the struct firmware that request_firmware_nowait() hands off, which is needed in some cases. Allow this by requiring the callback to free it (via release_firmware). Additionally, give it a gfp_t parameter -- all the current users call it from a GFP_KERNEL context so the GFP_ATOMIC isn't necessary. This also marks an API break which is useful in a sense, although that is obviously not the primary purpose of this change. Signed-off-by: Johannes Berg <[email protected]> Acked-by: Marcel Holtmann <[email protected]> Cc: Ming Lei <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: David Woodhouse <[email protected]> Cc: Pavel Roskin <[email protected]> Cc: Abhay Salunke <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2009-12-04tree-wide: fix assorted typos all over the placeAndré Goddard Rosa1-1/+1
That is "success", "unknown", "through", "performance", "[re|un]mapping" , "access", "default", "reasonable", "[con]currently", "temperature" , "channel", "[un]used", "application", "example","hierarchy", "therefore" , "[over|under]flow", "contiguous", "threshold", "enough" and others. Signed-off-by: André Goddard Rosa <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
2009-06-15firmware: atm/ueagle-atm: prepare for FIRMWARE_NAME_MAX removalSamuel Ortiz1-4/+5
We're going to remove the FIRMWARE_NAME_MAX definition in order to avoid any firmware name length restriction. This patch replaces the shared FIRMWARE_NAME_MAX definition with a ueagle local one. Signed-off-by: Samuel Ortiz <[email protected]> Cc: Damien Bergamini <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2009-05-08USB: cxacru: Fix negative dB outputSimon Arlott1-2/+8
Values of dB between -0.99 and -0.01 will be output with the wrong sign. This converts the negative value to positive and outputs it with a "-" prefix. Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2009-03-30trivial: Fix misspelling of firmwareNick Andrew1-1/+1
Fix misspelling of firmware. Signed-off-by: Nick Andrew <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
2009-03-17USB: atm/cxacru, fix lock imbalanceJiri Slaby1-1/+2
We do not hold mutex in one place in cxacru_cm, but unlock it on fail path. Fix this. Signed-off-by: Jiri Slaby <[email protected]> Cc: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-10-27net: convert more to %pMJohannes Berg2-7/+2
A number of places still use %02x:...:%02x because it's in debug statements or for no real reason. Make a few of them use %pM. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-10-22USB: Speedtouch: add pre_reset and post_reset routinesAlan Stern1-0/+12
This patch (as1150) fixes a problem in the speedtch driver. When it resets the modem during probe it will be unbound from the other interfaces it has claimed, because it doesn't define a pre_reset and a post_reset method. The patch defines "do-nothing" methods. This fixes Bugzilla #11767. Signed-off-by: Alan Stern <[email protected]> Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-10-17USB: remove warn() macro from usb driversGreg Kroah-Hartman3-8/+14
USB should not be having it's own printk macros, so remove warn() and use the system-wide standard of dev_warn() wherever possible. In the few places that will not work out, use a basic printk(). Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-09-23usbatm: Use skb_queue_walk_safe() instead of by-hand implementation.David S. Miller1-3/+2
Signed-off-by: David S. Miller <[email protected]>
2008-08-23removed unused #include <linux/version.h>'sAdrian Bunk1-1/+0
This patch lets the files using linux/version.h match the files that #include it. Signed-off-by: Adrian Bunk <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2008-08-13USB: cxacru: Fix printk format flag in error messageSimon Arlott1-1/+1
"#%x" should have been "%#x" Signed-off-by: Simon Arlott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-07-21USB: AccessRunner: avoid unnecessary memsetChristophe Jaillet1-1/+0
Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc (i.e. 'card_info' array of the structure 'instance'). Signed-off-by: Christophe Jaillet <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-07-21USB: speedtch.c fix sparse shadowed variable warningHarvey Harrison1-1/+0
i is used only as a for-loop index no need to declare another. drivers/usb/atm/speedtch.c:832:7: warning: symbol 'i' shadows an earlier one drivers/usb/atm/speedtch.c:766:6: originally declared here Signed-off-by: Harvey Harrison <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-07-10cxacru: treat firmware data as constDavid Woodhouse1-1/+1
Signed-off-by: David Woodhouse <[email protected]>
2008-07-10ueagle-atm: treat firmware data as constDavid Woodhouse1-9/+11
Signed-off-by: David Woodhouse <[email protected]>
2008-05-02USB: Remove redundant dependencies on USB_ATM.Robert P. J. Day1-4/+0
Given that the bulk of the Kconfig file is enclosed in "if USB_ATM", remove the unnecessary dependencies. Signed-off-by: Robert P. J. Day <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-04-29usb: use get/put_unaligned_* helpersHarvey Harrison1-25/+23
Signed-off-by: Harvey Harrison <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Cc: Alan Stern <[email protected]> Cc: David Brownell <[email protected]> Cc: Al Viro <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2008-04-28drivers/usb annotations and fixesAl Viro2-8/+10
* endianness annotations * endianness fixes * missing get_unaligned/put_unaligned It's pretty much all over the place, changes to different files are independent. Signed-off-by: Al Viro <[email protected]> Serial-parts-Acked-by: Alan Cox <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2008-04-24USB: remove unnecessary type casting of urb->contextMing Lei1-1/+1
urb->context code cleanup Signed-off-by: Ming Lei <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-04-24USB: replace remaining __FUNCTION__ occurrencesHarvey Harrison1-3/+3
__FUNCTION__ is gcc-specific, use __func__ Signed-off-by: Harvey Harrison <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-04-24USB: usbatm: convert heavy init dances to kthread APIPavel Emelyanov2-13/+16
This is an attempt to kill two birds with one stone. First, we kill one more user of kernel_thread, which is scheduled for removal. Second - we kill one of the last users of kill_proc - the function which is also to be removed, because it uses a pid_t which is not safe now. Signed-off-by: Pavel Emelyanov <[email protected]> Signed-off-by: Duncan Sands <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-04-18drivers: Remove unnecessary inclusions of asm/semaphore.hMatthew Wilcox1-1/+0
None of these files use any of the functionality promised by asm/semaphore.h. It's possible that they rely on it dragging in some unrelated header file, but I can't build all these files, so we'll have fix any build failures as they come up. Signed-off-by: Matthew Wilcox <[email protected]>
2008-02-01USB: Use menuconfig objectsDenis Cheng1-5/+4
commit 04d06ad0f1fdb499af84ae3d7969e2136a462f38 have added menuconfig support for the whole USB Kconfig, but there are still menuconfig need for usb/serial, usb/atm, and usb/gadget, so that the user can disable all the options in that menu at once instead of having to disable each option separately. Signed-off-by: Denis Cheng <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: Spelling fixesJoe Perches1-1/+1
Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2008-02-01USB: Add missing "space" to printk messagesJoe Perches1-2/+2
Signed-off-by: Joe Perches <[email protected]> Acked-by: David Brownell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-14signedness: module_param_array nump argumentAl Viro2-2/+2
... should be unsigned int Signed-off-by: Al Viro <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2007-10-12USB: cxacru: Use appropriate logging for errorsSimon Arlott1-15/+28
When an error occurs, existing logging uses dbg() so the cause of a problem is hard to determine. Error conditions shouldn't only be properly reported with debugging enabled. A side effect of this change is that when an uninitialised device is started, a log message similar to the following is sent: cxacru 5-2:1.0: receive of cm 0x90 failed (-104) This is normal - the device did not respond so firmware will be loaded. Signed-off-by: Simon Arlott <[email protected]> Acked-by: Duncan Sands <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12UEAGLE: CosmeticStanislaw Gruszka1-4/+3
Update copyrights and remove not necessary warning (ueagle-atm works well on suspend/resume). Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12UEAGLE: Do not sleep when device is disconnectedStanislaw Gruszka1-8/+19
Do not sleep in kernel thread when device is disconnected, this make faster suspending and module unloading. Use one wait queue for sleeping. Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12UEAGLE: Avoid keyboard driver blockingStanislaw Gruszka1-11/+20
Ueagle-atm driver load DSP firmware in function, which is running from common workqueue. In some (error) circumstances loading firmware may sleep for long periods (even 60 seconds, depending on timeout). This block keyboard driver, which also use common workqueue. To fix problem use custom workqueue in ueagle-atm. Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12UEAGLE: Allow user to choose input interface alternate settingStanislaw Gruszka1-16/+12
Let's user control how much USB bus bandwidth will be reserved by ueagle-atm device. This make possible to share bus with other devices when ueagle-atm driver works in isochronous mode. Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-10-12UEAGLE: Devolo and Elsa chipsets supportStanislaw Gruszka1-26/+88
Support for Devolo and Elsa chipsets. These chipsets have no information about ADSL annex (line type) encoded in USB descriptors. Driver try to get this information from USB VID and PID or it can be explicitly set by the user through module parameter. Thanks to Johann Hanne, whose make most of this patch. Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.