aboutsummaryrefslogtreecommitdiff
path: root/drivers/scsi
AgeCommit message (Collapse)AuthorFilesLines
2014-07-25scsi: ufs: fix endianness sparse warningsSujit Reddy Thumma1-3/+4
Fix many warnings with incorrect endian assumptions which makes the code unportable to new architectures. The UFS specification defines the byte order as big-endian for UPIU structure and little-endian for the host controller transfer/task management descriptors. Signed-off-by: Sujit Reddy Thumma <[email protected]> Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25scsi: ufs: make undeclared functions staticSujit Reddy Thumma1-2/+3
Make undeclared functions static to suppress warnings from sparse tool. Signed-off-by: Sujit Reddy Thumma <[email protected]> Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25bnx2i: Update driver version to 2.7.10.1Vikas Chaudhary1-2/+2
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: fix a memory leak in nvmd_respTomas Henzl1-6/+2
Instead of copying information to fw_control_context free it. The task is forgotten thus also the reference to fw_control_context and the completion thread takes the info from virt_ptr again. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: fix update_flashTomas Henzl1-3/+3
The driver checks the return valu, but after he tries to wait_for_completion which might never happen. Also the ioctl buffer is freed at the end of the function, so the first removal is not needed. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: fix a memory leak in flash_updateTomas Henzl1-6/+6
ccb->fw_control_context is copied to local fw_control_context and the local variable is never used later Free ccb->fw_control_context. The task is forgotten thus also the reference to fw_control_context and the completion thread takes the info from virt_ptr again. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: Cleaning up uninitialized variablesRickard Strandqvist1-4/+2
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppche Signed-off-by: Rickard Strandqvist <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: Fix to remove null pointer checks that could never happenRickard Strandqvist1-1/+1
Removal of null pointer checks that could never happen Signed-off-by: Rickard Strandqvist <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: more fixes to honor return valueTomas Henzl2-3/+24
The driver ignores the return value in a lot of places, fix it at least somewhere (and release the resources in such cases), to avoid that bad things happen. A memory leak is fixed too. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: add a new spinlock to protect the CCBTomas Henzl3-1/+8
Patch adds a new spinlock to protect the ccb management. It may happen that concurrent threads become the same tag value from the 'alloc' function', the spinlock prevents this situation. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: honor return valueTomas Henzl2-17/+58
The driver ignores the return value in a lot of places, fix it at least somewhere (and release the resources in such cases), to avoid that bad things happen. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: clean bitmap management functionsTomas Henzl3-30/+12
In the driver two different functions are used to free the same resource, this patch makes the code easier to read. In addittion to that, some minor optimisations were made too. Signed-off-by: Tomas Henzl <[email protected]> Acked-by: Suresh Thiagarajan <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25pm8001: Fix hibernation issueBradley Grove1-2/+10
During hibernation, the HBA firmware may lose power and forget the device id info. This causes the HBA to reject IO upon resume. The fix is to call the libsas power management routines to make the domain device forgetful. This fixes bug 76681: https://bugzilla.kernel.org/show_bug.cgi?id=76681 Signed-off-by: Bradley Grove <[email protected]> Acked-by: Jack Wang <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt3sas: delay scsi_add_host call to work with scsi-mqReddy, Sreekanth2-15/+13
In _scsih_probe, delay the call to scsi_add_host until the host has been fully set up. Otherwise, the default .can_queue value of 1 causes scsi-mq to set the block layer request queue size to its minimum size, resulting in awful performance. In _scsih_probe error handling, call mpt3sas_base_detach rather than scsi_remove_host to properly clean up in reverse order. In _scsih_remove, call scsi_remove_host earlier to clean up in reverse order. Signed-off-by: Robert Elliott <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Nagalakshmi Nandigama <[email protected]> Signed-off-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt2sas: delay scsi_add_host call to work with scsi-mqReddy, Sreekanth2-14/+13
In _scsih_probe, delay the call to scsi_add_host until the host has been fully set up. Otherwise, the default .can_queue value of 1 causes scsi-mq to set the block layer request queue size to its minimum size, resulting in awful performance. In _scsih_probe error handling, call mpt3sas_base_detach rather than scsi_remove_host to properly clean up in reverse order. In _scsih_remove, call scsi_remove_host earlier to clean up in reverse order. Signed-off-by: Robert Elliott <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Nagalakshmi Nandigama <[email protected]> Signed-off-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failureK. Y. Srinivasan1-0/+7
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Note that there is sufficient sense information to support scsi error handling even in this case. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25drivers: scsi: storvsc: Set srb_flags in all casesK. Y. Srinivasan1-7/+5
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the Windows host require this. The host validates the command and SRB flags prior to passing the command down to native driver stack. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25Drivers: scsi: storvsc: Implement a eh_timed_out handlerK. Y. Srinivasan1-0/+12
On Azure, we have seen instances of unbounded I/O latencies. To deal with this issue, implement handler that can reset the timeout. Note that the host gaurantees that it will respond to each command that has been issued. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> [hch: added a better comment explaining the issue] Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol versionK. Y. Srinivasan1-7/+10
Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle are pre-win8 and post-win8. In WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version. Make adjustments to correctly handle this. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25Drivers: scsi: storvsc: Filter commands based on the storage protocol versionK. Y. Srinivasan1-3/+13
Going forward it is possible that some of the commands that are not currently implemented will be implemented on future Windows hosts. Even if they are not implemented, we are told the host will corrrectly handle unsupported commands (by returning appropriate return code and sense information). Make command filtering depend on the host version. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the HostK. Y. Srinivasan1-1/+1
Set cmd_per_lun to reflect value supported by the Host. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25Drivers: scsi: storvsc: Change the limits to reflect the values on the hostK. Y. Srinivasan1-16/+31
Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. Signed-off-by: K. Y. Srinivasan <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: fix DMA mask settingAkinobu Mita2-26/+22
If the controller doesn't support 64-bit addressing mode, it must not set the DMA mask to 64-bit. But it's unconditionally trying to set to 64-bit without checking 64-bit addressing support in the controller capabilities. It was correctly checked before commit 3b1d05807a9a68c6d0580e9248247a774a4d3be6 ("[SCSI] ufs: Segregate PCI Specific Code"), this aims to restores the correct behaviour. To achieve this in a generic way, firstly we should push down the DMA mask setting routine ufshcd_set_dma_mask() from PCI glue driver to core driver in order to do it for both PCI glue driver and Platform glue driver. Secondly, we should change pci_ DMA mapping API to dma_ DMA mapping API because core driver is independent of glue drivers. Signed-off-by: Akinobu Mita <[email protected]> Acked-by: Santosh Y <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: adjust queue settings to PRDT limitationsAkinobu Mita2-0/+20
The data byte count field of PRDT indicates the length of data block which is a segment of data transfer for SCSI commands. The value of this field shall have Dword granularity and the the maximum of length is 256KB. This adjusts dma pad mask and max segment size to the above-mentioned PRDT limitations. Signed-off-by: Akinobu Mita <[email protected]> Reviewed-by: Subhash Jadavani <[email protected]> Tested-by: Dolev Raviv <[email protected]> Acked-by: Vinayak Holikatti <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: Fix sending unsupported SCSI commandSujit Reddy Thumma1-0/+3
UFS 1.1 specification does not support MAINTENANCE IN(0xA3) SCSI command and hence it doesn't support REPORT SUPPORTED OPERATION CODES as well. Change-Id: Ic09c5b46b2511b1c28db478023c32b898ac69e6d Signed-off-by: Sujit Reddy Thumma <[email protected]> Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: read door bell register after clearing interrupt aggregationDolev Raviv1-33/+34
In interrupt context, after reading and comparing the UTRLDBR to hba->outstanding_request and before resetting the interrupt aggregation, there might be completion of another transfer request (TR). Such TRs might get stuck, pending, until the next interrupt is generated (if any). Changing the sequence of resetting the interrupt aggregation first and then reading UTRLDBR status, will assure that completed TRs won't get stuck pending. Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: Fix queue depth handling for best effort casesSujit Reddy Thumma1-55/+42
Some UFS devices may expose bLUQueueDepth field as zero indicating that the queue depth depends on the number of resources available for LUN at a particular instant to handle the outstanding transfer requests. Currently, when response for SCSI command is TASK_FULL the LLD decrements the queue depth but fails to increment when the resources are available. The scsi mid-layer handles the change in queue depth heuristically and offers simple interface with ->change_queue_depth. Signed-off-by: Sujit Reddy Thumma <[email protected]> Signed-off-by: Dolev Raviv <[email protected]> Acked-by: Santosh Y <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: Logical Unit (LU) command queue depthDolev Raviv2-1/+65
Some of the UFS devices may support different number of commands that can be queued per LU. At the current implementation, SW configure each of the UFS devices LU's according to the controller capability. In this patch the queue depth available per LU is read and updated in the LU's SW structure. Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Raviv Shvili <[email protected]> Acked-by: Santosh Y <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: device query status and size checkDolev Raviv1-17/+32
Check query response status before copying the response. Add descriptor query response size check, before copying it to buffer. Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Raviv Shvili <[email protected]> Acked-by: Santosh Y <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25ufs: query descriptor APIDolev Raviv2-28/+128
Introduces the API for sending queries with descriptors. A descriptor is a block or page of parameters that describe the device. The descriptors are classified into types and can range in size from 2 bytes through 255 bytes. All descriptors have a length value as their first element, and a type identification element as their second byte. All descriptors are readable and some may be write once. They are accessed using their type, index and selector. Signed-off-by: Dolev Raviv <[email protected]> Signed-off-by: Raviv Shvili <[email protected]> Acked-by: Santosh Y <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25be2iscsi: Fix memory leak in mgmt_set_ip()Maurizio Lombardi1-9/+11
The if_info pointer is not released by the mgmt_set_ip() function Signed-off-by: Maurizio Lombardi <[email protected]> Reviewed-by: Tomas Henzl <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25virtio-scsi: Implement change_queue_depth for virtscsi targetsVenkatesh Srinivas1-0/+33
change_queue_depth allows changing per-target queue depth via sysfs. It also allows the SCSI midlayer to ramp down the number of concurrent inflight requests in response to a SCSI BUSY status response and allows the midlayer to ramp the count back up to the device maximum when the BUSY condition has resolved. Signed-off-by: Venkatesh Srinivas <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25virtio-scsi: replace target spinlock with seqcountMing Lei1-13/+29
The spinlock of tgt_lock is only for serializing read and write req_vq, one lockless seqcount is enough for the purpose. On one 16core VM with vhost-scsi backend, the patch can improve IOPS with 3% on random read test. Signed-off-by: Ming Lei <[email protected]> [Add initialization in virtscsi_target_alloc. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctlStephen M. Cameron1-1/+1
When copy_from_user fails, return -EFAULT, not -ENOMEM Signed-off-by: Stephen M. Cameron <[email protected]> Reported-by: Robert Elliott <[email protected]> Reviewed-by: Joe Handzik <[email protected]> Reviewed-by: Scott Teel <[email protected]> Reviewed by: Mike MIller <[email protected]> Cc: <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: remove online devices from offline device listStephen M. Cameron1-1/+5
When devices come on line, they should be removed from the list of offline devices that are monitored. Signed-off-by: Stephen M. Cameron <[email protected]> Reviewed-by: Scott Teel <[email protected]> Reviewed-by: Joe Handzik <[email protected]> Reviewed by: Mike MIller <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: fix non-x86 buildsArnd Bergmann1-2/+2
commit 28e134464734 "[SCSI] hpsa: enable unit attention reporting" turns on unit attention notifications, but got the change wrong for all architectures other than x86, which now store an uninitialized value into the device register. Gcc helpfully warns about this: ../drivers/scsi/hpsa.c: In function 'hpsa_set_driver_support_bits': ../drivers/scsi/hpsa.c:6373:17: warning: 'driver_support' is used uninitialized in this function [-Wuninitialized] driver_support |= ENABLE_UNIT_ATTN; ^ This moves the #ifdef so only the prefetch-enable is conditional on x86, not also reading the initial register contents. Signed-off-by: Arnd Bergmann <[email protected]> Fixes: 28e134464734 "[SCSI] hpsa: enable unit attention reporting" Cc: [email protected] # v3.14+ Acked-by: Stephen M. Cameron <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: do not unconditionally copy sense dataRobert Elliott1-8/+8
Signed-off-by: Robert Elliott <[email protected]> Signed-off-by: Stephen M. Cameron <[email protected]> Reviewed-by: Stephen M. Cameron <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: fix 6-byte READ/WRITE with 0 length data xferStephen M. Cameron1-1/+2
a 6-byte READ/WRITE CDB with a 0 block data transfer really means a 256 block data transfer. The RAID mapping code failed to handle this case. For 10/12/16 byte READ/WRITEs, 0 just means no data should be transferred, and should not trigger BUG_ON. Signed-off-by: Stephen M. Cameron <[email protected]> Reported-by: Robert Elliott <[email protected]> Reviewed-by: Robert Elliott <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25hpsa: make hpsa_init_one return -ENOMEM if allocation of h->lockup_detected ↵Stephen M. Cameron1-1/+3
fails Signed-off-by: Stephen M. Cameron <[email protected]> Reviewed-by: Joe Handzik <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25bnx2fc: Rebranding bnx2fc driverSaurav Kashyap11-14/+72
QLogic has acquired the NetXtremeII products and drivers from Broadcom. This patch re-brands bnx2fc driver as a QLogic driver Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Acked-by: Eddie Wai <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25bnx2i: Rebranding bnx2i driverVikas Chaudhary8-19/+33
QLogic has acquired the NetXtremeII products and drivers from Broadcom. This patch re-brands bnx2i driver as a QLogic driver Signed-off-by: Vikas Chaudhary <[email protected]> Acked-by: Eddie Wai <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt3sas: Rework the MSI-X grouping codeMartin K. Petersen1-52/+21
On systems with a non power-of-two CPU count the existing MSI-X grouping code failed to distribute interrupts correctly. Rework the code to handle arbitrary processor counts. Also remove the hardcoded upper limit on the number of processors so we can boot on large systems. Signed-off-by: Martin K. Petersen <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt2sas: Rework the MSI-X grouping codeMartin K. Petersen1-41/+23
On systems with a non power-of-two CPU count the existing MSI-X grouping code failed to distribute interrupts correctly. Rework the code to handle arbitrary processor counts. Also remove the hardcoded upper limit on the number of processors so we can boot on large systems. Signed-off-by: Martin K. Petersen <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt3sas: combine fw_event_work and its event_dataJoe Lawrence1-25/+31
Tack the firmware reply event_data payload to the end of its corresponding struct fw_event_work allocation. This matches the convention in the mptfusion driver and simplifies the code. This avoids the following smatch warning: drivers/scsi/mpt3sas/mpt3sas_scsih.c:2519 mpt3sas_send_trigger_data_event() warn: possible memory leak of 'fw_event' Signed-off-by: Joe Lawrence <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt3sas: correct scsi_{target,device} hostdata allocationJoe Lawrence1-2/+4
In _scsih_{slave,target}_alloc, an incorrect structure type is passed to sizeof() when allocating storage for hostdata. Luckily larger structure types were used, so at least the wrong sizes were safe: struct scsi_device (1784 bytes) > struct MPT3SAS_DEVICE (24 bytes) struct scsi_target (760 bytes) > struct MPT3SAS_TARGET (32 bytes) This fixes the following smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:1166 _scsih_target_alloc() warn: struct type mismatch 'MPT3SAS_TARGET vs scsi_target' drivers/scsi/mpt3sas/mpt3sas_scsih.c:1280 _scsih_slave_alloc() warn: struct type mismatch 'MPT3SAS_DEVICE vs scsi_device' Signed-off-by: Joe Lawrence <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt2sas: annotate ioc->reply_post_host_index as __iomemJoe Lawrence2-5/+6
The MPT2SAS_ADAPTER reply_post_host_index[] holds calculated addresses in memory mapped register space. Add an "__iomem" annotation to silence the following sparse warnings: drivers/scsi/mpt2sas/mpt2sas_base.c:1006:43: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned long long [usertype] *<noident> drivers/scsi/mpt2sas/mpt2sas_base.c:4299:22: warning: cast removes address space of expression drivers/scsi/mpt2sas/mpt2sas_base.c:4303:27: warning: cast removes address space of expression Signed-off-by: Joe Lawrence <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt2sas: combine fw_event_work and its event_dataJoe Lawrence1-22/+30
Tack the firmware reply event_data payload to the end of its corresponding struct fw_event_work allocation. This matches the convention in the mptfusion driver and simplifies the code. Signed-off-by: Joe Lawrence <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25mpt2sas: correct scsi_{target,device} hostdata allocationJoe Lawrence1-2/+4
In _scsih_{slave,target}_alloc, an incorrect structure type is passed to sizeof() when allocating storage for hostdata. Luckily larger structure types were used, so at least the wrong sizes were safe: struct scsi_device (1784 bytes) > struct MPT2SAS_DEVICE (24 bytes) struct scsi_target (760 bytes) > struct MPT2SAS_TARGET (40 bytes) This fixes the following smatch warnings: drivers/scsi/mpt2sas/mpt2sas_scsih.c:1295 _scsih_target_alloc() warn: struct type mismatch 'MPT2SAS_TARGET vs scsi_target' drivers/scsi/mpt2sas/mpt2sas_scsih.c:1409 _scsih_slave_alloc() warn: struct type mismatch 'MPT2SAS_DEVICE vs scsi_device' Signed-off-by: Joe Lawrence <[email protected]> Acked-by: Sreekanth Reddy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-253w-xxxx: fix mis-aligned struct accessesArnd Bergmann1-2/+2
Building an allmodconfig ARM kernel, I get multiple such warnings because of a spinlock contained in packed structure in the 3w-xxxx driver: ../drivers/scsi/3w-xxxx.c: In function 'tw_chrdev_ioctl': ../drivers/scsi/3w-xxxx.c:1001:68: warning: mis-aligned access used for structure member [-fstrict-volatile-bitfields] timeout = wait_event_timeout(tw_dev->ioctl_wqueue, tw_dev->chrdev_request_id == TW_IOCTL_CHRDEV_FREE, timeout); ^ ../drivers/scsi/3w-xxxx.c:1001:68: note: when a volatile object spans multiple type-sized locations, the compiler must choose between using a single mis-aligned access to preserve the volatility, or using multiple aligned accesses to avoid runtime faults; this code may fail at runtime if the hardware does not allow this access The same bug apparently was present in 3w-sas and 3w-9xxx, but has been fixed in the past. This patch uses the same fix by moving the pragma in front of the TW_Device_Extension definition, so it only covers hardware structures. Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Adam Radford <[email protected]> Cc: Adam Radford <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-07-25NCR53c406a: don't call free_dma() by defaultArnd Bergmann1-1/+1
The NCR53c406a scsi driver normally does not use DMA, unless the USE_PIO macro is disabled by modifying the source code. The call to free_dma() for some reason uses #ifdef USE_DMA, which does not do the right thing, since USE_DMA is defined as a boolean that is either 0 or 1, but always present. One case where it gets in the way is randconfig builds on ARM, which depending on the configuration does not provide a free_dma() function, causing this build error: drivers/scsi/NCR53c406a.c: In function 'NCR53c406a_release': drivers/scsi/NCR53c406a.c:600:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration] free_dma(shost->dma_channel); ^ This changes the code to use #if USE_DMA, to match the rest of the file, which seems to be what the author intended. Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Finn Thain <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.